pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Thomas Munro <thomas.munro@gmail.com>
To: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: James Hilliard <james.hilliard1@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date: Sat, 3 Jul 2021 13:38:53 +0200
Message-ID: <6ac601c7-9a72-d354-cfaa-03a66108c778@enterprisedb.com> (raw)
In-Reply-To: <CA+hUKGK6jGpC0dvkWxGDeuMtJo8qhN-a9Dmd40Esnovq7N=eBQ@mail.gmail.com>
References: <20210122193230.25295-1-james.hilliard1@gmail.com>
	<CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
	<ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net>
	<CADvTj4qwmJgqWB5zStrPAxRL2DsPThtwOubAAUPUSh0XSY0JTw@mail.gmail.com>
	<CA+hUKGJ9Fsy3Hdgs8BpgBd+J06qo9=4LdGBK5sWxzBt08fENgg@mail.gmail.com>
	<CADvTj4oSfH8qN-v_W1ydbA5uJkChxCj8RntwsH-EStytygtALg@mail.gmail.com>
	<CA+hUKGJP4nCdi1jKQ5rYJpNwMKVskOA6k=yW36K254ok_6_AZg@mail.gmail.com>
	<2781003.1617083917@sss.pgh.pa.us>
	<CA+OCxoxNysU7U7VsR2aos5PnapRU6VPWcwGjE7A_aL0ibk4K2w@mail.gmail.com>
	<CANFyU95MMxUDF7k4TqhPLMQ9KDyZeET26ocpvmbr8tzawrC1nQ@mail.gmail.com>
	<CA+hUKGK6jGpC0dvkWxGDeuMtJo8qhN-a9Dmd40Esnovq7N=eBQ@mail.gmail.com>

On 21.06.21 07:22, Thomas Munro wrote:
> I'm not personally against the proposed change.  I'll admit there is
> something annoying about Apple's environment working in a way that
> doesn't suit traditional configure macros that have been the basis of
> portable software for a few decades, but when all's said and done,
> configure is a Unix wars era way to make things work across all the
> Unixes, and most of them are long gone, configure itself is on the way
> out, and Apple's still here, so...

I think this change is perfectly appropriate (modulo some small cleanups).

The objection was that you cannot reliably use AC_CHECK_FUNCS (and 
therefore AC_REPLACE_FUNCS) anymore, but that has always been true, 
since AC_CHECK_FUNCS doesn't handle macros, compiler built-ins, and 
functions that are not declared, and any other situation where looking 
for a symbol in a library is not the same as checking whether the symbol 
actual works for your purpose.  This is not too different from the long 
transition from "does this header file exists" to "can I compile this 
header file".

So in fact the correct way forward would be to get rid of all uses of 
AC_CHECK_FUNCS and related, and then this problem goes away by itself.






view thread (25+ messages)  latest in thread

Message-ID: <6ac601c7-9a72-d354-cfaa-03a66108c778@enterprisedb.com>
Permalink:  ../6ac601c7-9a72-d354-cfaa-03a66108c778@enterprisedb.com/
Also on:    postgresql.org/message-id/6ac601c7-9a72-d354-cfaa-03a66108c778@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, thomas.munro@gmail.com, sandeep.thakkar@enterprisedb.com, dpage@pgadmin.org, tgl@sss.pgh.pa.us, james.hilliard1@gmail.com, david@pgmasters.net, pgsql-hackers@lists.postgresql.org, s.shinderuk@postgrespro.ru
  Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
  In-Reply-To: <6ac601c7-9a72-d354-cfaa-03a66108c778@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox