From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: make installcheck-world in a clean environment
Date: Tue, 31 Jul 2018 10:10:12 +0300
Message-ID: <6c7747ab-e99b-c537-d8c5-9be8378573ee@gmail.com> (raw)
In-Reply-To: <15981.1532988967@sss.pgh.pa.us>
References: <bfee872b-ab16-ec7c-8f8a-b3949add1c1b@gmail.com>
<CA+TgmoafXiYMj6ROd09PxLFQ_dpurP1FJOL4ZwDonCkPeSubWg@mail.gmail.com>
<aff02bd6-20c9-0b6e-4e3c-a3428ce6568b@gmail.com>
<CA+TgmoZV08_6SXmag0hFkOurgWPjks6Jwyh+DeFXsCxLWLVjfw@mail.gmail.com>
<24834.1525712835@sss.pgh.pa.us>
<ec02a440-0346-4bdc-5118-0f7970d33c16@gmail.com>
<b36c96e5-05cf-aa0f-90a5-2276887170ce@2ndquadrant.com>
<beb142a3-aaf6-f6d7-2aae-69f7d65fb3d4@gmail.com>
<d50a2101-c8cc-1456-fd4c-c12edfa2549b@2ndquadrant.com>
<0401efec-68f1-679d-3ea3-21d4e8dd11af@gmail.com>
<15981.1532988967@sss.pgh.pa.us>
Hello Tom,
31.07.2018 01:16, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> 14.07.2018 13:57, Peter Eisentraut wrote:
>>> On 06.07.18 09:45, Alexander Lakhin wrote:
>>>> ./configure --enable-tap-tests
>>>> make install
>>>> make install -C contrib
>>>> chown -R postgres:postgres /usr/local/pgsql/
>>>> /usr/local/pgsql/bin/initdb -D /usr/local/pgsql/data
>>>> /usr/local/pgsql/bin/pg_ctl start -l logfile -D /usr/local/pgsql/data
>>>> /make clean/
>>>> # Also you can just install binary packages to get the same state.
>>>>
>>>> make installcheck-world
>>>> # This check fails.
> I remain pretty skeptical that this is a sensible way to proceed,
> especially not if what you're testing is installed binary packages.
> You're creating yet *another* hazard for version-skew-like problems,
> namely that there's no certainty that you gave configure arguments
> that're compatible with what the installed packages used.
I believe that `installed_instance_path\bin\pg_config --configure` can
show the arguments, which can be used to perform ./configure and then
make installcheck for binary packages.
I understand that it should be done on the same platform and with
exactly the same PG version, but I think it's the only right way to
check the binaries (to perform user-centric testing).
Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: make installcheck-world in a clean environment
In-Reply-To: <6c7747ab-e99b-c537-d8c5-9be8378573ee@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox