pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
Date: Sat, 11 Feb 2023 20:32:30 -0500
Message-ID: <734490.1676165550@sss.pgh.pa.us> (raw)
In-Reply-To: <20230212004254.3lp22a7bpkcjo3y6@awork3.anarazel.de>
References: <20230209215532.oomwhj5jyggmciq7@awork3.anarazel.de>
	<20230209221450.bkuozhhzlgpupx4d@awork3.anarazel.de>
	<3966340.1675981162@sss.pgh.pa.us>
	<20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
	<3972584.1675984746@sss.pgh.pa.us>
	<20230210000841.4chvtmr4gkrfsotb@awork3.anarazel.de>
	<3979957.1675988437@sss.pgh.pa.us>
	<20230210003555.kyhyqq3imgocs62k@awork3.anarazel.de>
	<3986263.1675989733@sss.pgh.pa.us>
	<718245.1676159640@sss.pgh.pa.us>
	<20230212004254.3lp22a7bpkcjo3y6@awork3.anarazel.de>

Hmmm ... ci autoconf build is now happy, but the Windows run complains
that none of the output files match.  I'm betting that this is a
Windows-newline problem, since I now see that indent.c opens both the
input and output files in default (text) mode.  I'm inclined to
change it to open the output file in binary mode while leaving the
input in text, which should have the effect of stripping \r if it's
present.

			regards, tom lane





view thread (22+ messages)  latest in thread

Message-ID: <734490.1676165550@sss.pgh.pa.us>
Permalink:  ../734490.1676165550@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/734490.1676165550@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Importing pg_bsd_indent into our source tree
  In-Reply-To: <734490.1676165550@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox