From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
Date: Fri, 22 Jul 2022 19:50:02 -0400
Message-ID: <774726.1658533802@sss.pgh.pa.us> (raw)
In-Reply-To: <754179.1658525051@sss.pgh.pa.us>
References: <20220722201945.wk22sn2evf4enztn@alvherre.pgsql>
<748838.1658522443@sss.pgh.pa.us>
<754179.1658525051@sss.pgh.pa.us>
I wrote:
> So it'll work in 3.81 (released 2006) and later, but not 3.80.
Confirmed that things are fine with 3.81.
> TBH my inclination here is to move our goalposts to say "we support
> gmake 3.81 and later".
Barring objections, I'll push the attached patch. I suppose we
could undo whatever dumbing-down was done in _create_recursive_target,
but is it worth troubling with?
regards, tom lane
Attachments:require-gmake-3.81.patch (text/x-diff, 2.3K) downloaddiff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgmlindex 32e0d3fd9d..70d188e2bc 100644--- a/doc/src/sgml/installation.sgml+++ b/doc/src/sgml/installation.sgml@@ -77,7 +77,7 @@ su - postgres
<primary>make</primary>
</indexterm>
- <acronym>GNU</acronym> <application>make</application> version 3.80 or newer is required; other+ <acronym>GNU</acronym> <application>make</application> version 3.81 or newer is required; other
<application>make</application> programs or older <acronym>GNU</acronym> <application>make</application> versions will <emphasis>not</emphasis> work.
(<acronym>GNU</acronym> <application>make</application> is sometimes installed under
the name <filename>gmake</filename>.) To test for <acronym>GNU</acronym>
diff --git a/src/Makefile.global.in b/src/Makefile.global.inindex bb177a8162..0d766cfd15 100644--- a/src/Makefile.global.in+++ b/src/Makefile.global.in@@ -872,11 +872,11 @@ install-strip:
# allows parallel make across directories and lets make -k and -q work
# correctly.
-# We need the $(eval) function and order-only prerequisites, which are-# available in GNU make 3.80. That also happens to be the version-# where the .VARIABLES variable was introduced, so this is a simple check.-ifndef .VARIABLES-$(error GNU make 3.80 or newer is required. You are using version $(MAKE_VERSION))+# We need the ability to export target-specific variables, which was+# added in GNU make 3.81. That also happens to be the version+# where the .FEATURES variable was introduced, so this is a simple check.+ifndef .FEATURES+$(error GNU make 3.81 or newer is required. You are using version $(MAKE_VERSION))
endif
# This function is only for internal use below. It should be called
@@ -884,7 +884,7 @@ endif
# given subdirectory. For the tree-wide all/install/check/installcheck cases,
# ensure we do our one-time tasks before recursing (see targets above).
# Note that to avoid a nasty bug in make 3.80,
-# this function has to avoid using any complicated constructs (like+# this function was written to not use any complicated constructs (like
# multiple targets on a line) and also not contain any lines that expand
# to more than about 200 bytes. This is why we make it apply to just one
# subdirectory at a time, rather than to a list of subdirectories.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, andrew@dunslane.net, pryzby@telsasoft.com, andres@anarazel.de
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
In-Reply-To: <774726.1658533802@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox