From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Extra quote_all_identifiers in _dumpOptions
Date: Tue, 9 Jul 2019 11:10:49 +0300
Message-ID: <7967be19-322c-ec5e-ac93-61a3c3092cce@postgrespro.ru> (raw)
In-Reply-To: <20190708233207.ovbrtkjnwhcznwpc@momjian.us>
References: <d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru>
<20190708233207.ovbrtkjnwhcznwpc@momjian.us>
On 09.07.2019 02:32, Bruce Momjian wrote:
>> diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h
>> index db30b54a92..8c0cedcd98 100644
>> --- a/src/bin/pg_dump/pg_backup.h
>> +++ b/src/bin/pg_dump/pg_backup.h
>> @@ -153,7 +153,6 @@ typedef struct _dumpOptions
>> int no_synchronized_snapshots;
>> int no_unlogged_table_data;
>> int serializable_deferrable;
>> - int quote_all_identifiers;
>> int disable_triggers;
>> int outputNoTablespaces;
>> int use_setsessauth;
>
> Wow, good catch. I thought C compilers would have reported this issue,
> but obviously not. Patch applied to head. Thanks.
Thank you, Bruce!
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Extra quote_all_identifiers in _dumpOptions
In-Reply-To: <7967be19-322c-ec5e-ac93-61a3c3092cce@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox