From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Extra quote_all_identifiers in _dumpOptions
Date: Thu, 27 Jun 2019 12:12:15 +0300
Message-ID: <d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru> (raw)
Hello hackers,
While working on pg_dump I noticed the extra quote_all_identifiers in
_dumpOptions struct. I attached the patch.
It came from refactoring by 0eea8047bf. There is also a discussion:
https://www.postgresql.org/message-id/CACw0%2B13ZUcXbj9GKJNGZTkym1SXhwRu28nxHoJMoX5Qwmbg_%2Bw%40mail...
Initially the patch proposed to use quote_all_identifiers of
_dumpOptions. But then everyone came to a decision to use global
quote_all_identifiers from string_utils.c, because fmtId() uses it.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Attachments:extra_quote_all_identifiers.patch (text/x-patch, 433B) downloaddiff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.hindex db30b54a92..8c0cedcd98 100644--- a/src/bin/pg_dump/pg_backup.h+++ b/src/bin/pg_dump/pg_backup.h@@ -153,7 +153,6 @@ typedef struct _dumpOptions
int no_synchronized_snapshots;
int no_unlogged_table_data;
int serializable_deferrable;
- int quote_all_identifiers;
int disable_triggers;
int outputNoTablespaces;
int use_setsessauth;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Extra quote_all_identifiers in _dumpOptions
In-Reply-To: <d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox