From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Sun, 06 Feb 2022 19:39:39 -0500
Message-ID: <803503.1644194379@sss.pgh.pa.us> (raw)
In-Reply-To: <YgBoyUzQxwpXwNWY@paquier.xyz>
References: <YfCZgF9iHVAL3MFr@paquier.xyz>
<YfCrPHDuJ0rnmQR4@paquier.xyz>
<YfPyt3fj7z2gVou9@paquier.xyz>
<9f05b844-3a54-5883-9d3b-b5df12cbce88@dunslane.net>
<YfSQBY88yRTRwjto@paquier.xyz>
<Yf9QN9jsIvzhhIsz@paquier.xyz>
<668240.1644130701@sss.pgh.pa.us>
<Yf9zFgb0r9EIPmrM@paquier.xyz>
<669599.1644131868@sss.pgh.pa.us>
<546d16e8-769a-9078-420a-d62e1e8345ff@dunslane.net>
<YgBoyUzQxwpXwNWY@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Feb 06, 2022 at 08:32:59AM -0500, Andrew Dunstan wrote:
>> But the commit really shouldn't have happened until we know that most
>> buildfarm owners have installed it. It should have waited wait not just
>> for the release but for widespread deployment. Otherwise we will just
>> lose any logging for an error that might appear.
> Would it be better if I just revert the change for now then and do it
> again in one/two weeks?
I don't see a need to revert it.
I note, though, that there's still not been any email to the buildfarm
owners list about this update.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew@dunslane.net, pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <803503.1644194379@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox