From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Sun, 6 Feb 2022 13:36:07 +0900
Message-ID: <Yf9QN9jsIvzhhIsz@paquier.xyz> (raw)
In-Reply-To: <YfSQBY88yRTRwjto@paquier.xyz>
References: <YefIHrNYTNH/PML4@paquier.xyz>
<45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
<Yek+uQp/kMn2O3aK@paquier.xyz>
<Ye4IDNnbMQ5IRxv9@paquier.xyz>
<20220125164529.GG23027@telsasoft.com>
<YfCZgF9iHVAL3MFr@paquier.xyz>
<YfCrPHDuJ0rnmQR4@paquier.xyz>
<YfPyt3fj7z2gVou9@paquier.xyz>
<9f05b844-3a54-5883-9d3b-b5df12cbce88@dunslane.net>
<YfSQBY88yRTRwjto@paquier.xyz>
On Sat, Jan 29, 2022 at 09:53:25AM +0900, Michael Paquier wrote:
> On Fri, Jan 28, 2022 at 06:27:29PM -0500, Andrew Dunstan wrote:
>> I have committed this. But it will take time to get every buildfarm own
>> to upgrade.
>
> Thanks for that.
So, it took me some time to get back to this thread, and looked at it
for the last couple of days... The buildfarm client v14 has been
released on the 29th of January, which means that we are good to go.
I have found one issue while reviewing things: the creation of the new
subdirectory and its contents should satisfy group permissions for the
new cluster's data folder, but we were not doing that properly as we
called GetDataDirectoryCreatePerm() after make_outputdirs() so we
missed the proper values for create_mode and umask(). The rest looked
fine, and I got a green CI run on my own repo. Hence, applied.
I'll keep an eye on the buildfarm, in case.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andrew@dunslane.net, pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, daniel@yesql.se, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <Yf9QN9jsIvzhhIsz@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox