From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Subject: Re: speeding up planning with partitions
Date: Fri, 9 Nov 2018 12:43:24 -0500
Message-ID: <806bfbbb-c41e-cc22-7761-841255e8a932@redhat.com> (raw)
In-Reply-To: <3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp>
References: <20181107033207.cdisp33ryrgeidef@alvherre.pgsql>
<f74d2f85-a9c3-f82d-188a-fcfe77911e78@lab.ntt.co.jp>
<3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp>
Hi Amit,
On 11/9/18 3:55 AM, Amit Langote wrote:
> And here are patches structured that way. I've addressed some of the
> comments posted by Imai-san upthread. Also, since David's patch to
> postpone PlannerInfo.total_pages calculation went into the tree earlier
> this week, it's no longer included in this set.
>
Thanks for doing the split this way. The patch passes check-world.
I ran a SELECT test using hash partitions, and got
Master v5
64: 6k 59k
1024: 283 59k
The non-partitioned case gives 77k. The difference in TPS between the
partition case vs. the non-partitioned case comes down to
set_plain_rel_size() vs. set_append_rel_size() under
set_base_rel_sizes(); flamegraphs for this sent off-list.
Best regards,
Jesper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, Langote_Amit_f8@lab.ntt.co.jp, alvherre@2ndquadrant.com, imai.yoshikazu@jp.fujitsu.com, david.rowley@2ndquadrant.com
Subject: Re: speeding up planning with partitions
In-Reply-To: <806bfbbb-c41e-cc22-7761-841255e8a932@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox