pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Erik Wienhold <ewie@ewie.name>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Treat <rob@xzilla.net>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Regression with large XML data input
Date: Tue, 29 Jul 2025 08:11:11 -0400
Message-ID: <865404.1753791071@sss.pgh.pa.us> (raw)
In-Reply-To: <93116cb2-e3e2-40bf-be9b-77a2f68fd10a@uni-muenster.de>
References: <1691195.1753383449@sss.pgh.pa.us>
	<1721385.1753385039@sss.pgh.pa.us>
	<7a9a9804-01d8-4489-a831-1a222bae6705@uni-muenster.de>
	<aILK3nMlw6pp-XhA@paquier.xyz>
	<CABV9wwOY3pH+pA0R1hSq5g_DXqeDaGWRuoBEE4QwWLfTiw+nKw@mail.gmail.com>
	<1944118.1753467686@sss.pgh.pa.us>
	<aIbb3TOq3XP923e5@paquier.xyz>
	<314265.1753669007@sss.pgh.pa.us>
	<aIbk39Uit4oAigig@paquier.xyz>
	<cc0bd778-9730-4ef9-98b3-a965f8895331@uni-muenster.de>
	<457dd309-158f-43cd-81d4-df7284f30d4f@ewie.name>
	<483421.1753727323@sss.pgh.pa.us>
	<628881.1753733767@sss.pgh.pa.us>
	<93116cb2-e3e2-40bf-be9b-77a2f68fd10a@uni-muenster.de>

Jim Jones <jim.jones@uni-muenster.de> writes:
> Out of curiosity, what's the reasoning behind keeping node_list instead
> of directly using parsed_nodes in the xmlParseBalancedChunkMemory call?

In the original coding, there was a hazard of the node list getting
leaked if the caller passed parsed_nodes == NULL.  Or at least I
thought there was.  It may be that all releases of libxml2 are smart
enough to free the node list if there's no way to pass it back,
but I guess we had reason not to trust it.  Possibly there's something
about that in the discussion that led up to 6082b3d5d, though I see
I neglected to mention it in the commit message.

			regards, tom lane





view thread (36+ messages)  latest in thread

Message-ID: <865404.1753791071@sss.pgh.pa.us>
Permalink:  ../865404.1753791071@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/865404.1753791071@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jim.jones@uni-muenster.de, ewie@ewie.name, michael@paquier.xyz, rob@xzilla.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Regression with large XML data input
  In-Reply-To: <865404.1753791071@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox