From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Christoph Berg <myon@debian.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Date: Wed, 31 Aug 2022 15:19:50 +0100
Message-ID: <877d2omr5l.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <Yw9VFHD1APjGRCec@msg.df7cb.de>
References: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
<357fec80-cb54-1455-0632-b23d844e5a68@enterprisedb.com>
<Yw8xAZhbvlzJR3Jf@msg.df7cb.de>
<Yw9MJ8/CPJ2bzi0Q@msg.df7cb.de>
<AF7104E5-8B27-4C84-8771-63972396E957@yesql.se>
<Yw9Rkn0UXvsIhACV@msg.df7cb.de>
<Yw9VFHD1APjGRCec@msg.df7cb.de>
Christoph Berg <myon@debian.org> writes:
> Re: To Daniel Gustafsson
>> "string containing" is again pretty boilerplatish, how about just
>> "contains"?
>
> Actually, just omitting the whole prefix works best.
>
> TG_WHEN (text)
>
> BEFORE, AFTER, or INSTEAD OF, depending on the trigger's definition.
The attached patch does not reflect this, did you attach an old version?
> I also shortened some "name of table" to just "table". Since the data
> type is "name", it's clear what "table" means.
I think it reads better with the definite article and initial capital,
e.g. "The table that triggered ….".
> <variablelist>
> <varlistentry>
> - <term><varname>NEW</varname></term>
> + <term><varname>NEW</varname> (record)</term>
The type names should still be wrapped in <type>, like they were before.
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, myon@debian.org, daniel@yesql.se, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
In-Reply-To: <877d2omr5l.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox