From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Fri, 07 Nov 2025 17:18:41 +0000
Message-ID: <87a50x92xa.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <2d6e23db-f2f8-44ce-ad7a-258612dd6409@eisentraut.org>
References: <aQ2O99S+VjEZSf3/@ip-10-97-1-34.eu-west-3.compute.internal>
<202511071335.iw4fygwd4rxo@alvherre.pgsql>
<aQ4KJws+Bx4C20nK@ip-10-97-1-34.eu-west-3.compute.internal>
<2d6e23db-f2f8-44ce-ad7a-258612dd6409@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> On 07.11.25 16:03, Bertrand Drouvot wrote:
>
>> +#define pg_attribute_deprecated(msg) [[deprecated(msg)]]
>> +#elif defined(__GNUC__) || defined(__clang__)
>
> The __clang__ part is not needed, because clang defines __GNUC__ also.
Or, to avoid having to know this, how about __has_attribute(deprecated)?
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, peter@eisentraut.org, bertranddrouvot.pg@gmail.com, alvherre@kurilemu.de, michael@paquier.xyz, hlinnaka@iki.fi, quanzongliang@yeah.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
In-Reply-To: <87a50x92xa.fsf@wibble.ilmari.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox