pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should contrib modules install .h files?
Date: Sat, 15 Sep 2018 20:46:34 +0100
Message-ID: <87zhwik1gm.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <87bmag8o41.fsf@news-spur.riddles.org.uk>
References: <87h8lhoevw.fsf@news-spur.riddles.org.uk>
	<63819.1530544945@sss.pgh.pa.us>
	<878t6to8j9.fsf@news-spur.riddles.org.uk>
	<874lhho071.fsf@news-spur.riddles.org.uk>
	<67427.1530738056@sss.pgh.pa.us>
	<87po02m0bh.fsf@news-spur.riddles.org.uk>
	<87in5tnafh.fsf@news-spur.riddles.org.uk>
	<87efghn7js.fsf@news-spur.riddles.org.uk>
	<87a7r5n4n2.fsf@news-spur.riddles.org.uk>
	<87o9enb4h7.fsf@news-spur.riddles.org.uk>
	<20180731201700.zfscje7clxiljvjl@alap3.anarazel.de>
	<CAH2-Wz=imVrbydSkBH95y3w7ZU7XffE7-LW0R+LjfZrXnyz-dw@mail.gmail.com>
	<11978.1533073999@sss.pgh.pa.us>
	<CA+TgmoZB9fVOd-8ZSWLaKX_TVAV9y0+7YrUn8vbpAPL_4XmGPw@mail.gmail.com>
	<1836.1533221640@sss.pgh.pa.us>
	<87lg9oaghh.fsf@news-spur.riddles.org.uk>
	<25706.1533229991@sss.pgh.pa.us>
	<87o9ej8bgl.fsf@news-spur.riddles.org.uk>
	<11318.1533487874@sss.pgh.pa.us>
	<87ftzs8prv.fsf@news-spur.riddles.org.uk>
	<87bmag8o41.fsf@news-spur.riddles.org.uk>

>>>>> "Andrew" == Andrew Gierth <andrew@tao11.riddles.org.uk> writes:

 Andrew> Here's a patch that fixes (not necessarily in the best way) the
 Andrew> PGXS builds of all the contrib/*_pl{perl,python} modules.

 Andrew> Oh, obviously this patch doesn't fix the windows Install.pm
 Andrew> yet, but that'd be easier to do after finalizing the list of
 Andrew> include files to install.

So while looking into this, I found that to the best of my ability to
determine, the windows Install.pm has _never_ installed the plperl or
plpython header files. That's more than I'm in a position to fix, having
no windows box to test with.

So what I propose to do is to commit a cleaned-up version of the patch
posted above, with these changes:

 - install all the plpy_*.h headers, not just a few; I know of no reason
   to exclude any of them, and in the absence of feedback it seems
   better to install them all;

 - tidy up the makefile variables in the python transform modules to
   remove some duplication

 - fix Mkvcbuild.pm to account for the changes

This will allow hstore_plperl etc. to stand as examples of how to do
cross-module #includes both in and out of tree.

I'll post the patch for review shortly.

-- 
Andrew (irc:RhodiumToad)




view thread (81+ messages)  latest in thread

Message-ID: <87zhwik1gm.fsf@news-spur.riddles.org.uk>
Permalink:  ../87zhwik1gm.fsf@news-spur.riddles.org.uk/
Also on:    postgresql.org/message-id/87zhwik1gm.fsf@news-spur.riddles.org.uk

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com, pg@bowt.ie, andres@anarazel.de
  Subject: Re: Should contrib modules install .h files?
  In-Reply-To: <87zhwik1gm.fsf@news-spur.riddles.org.uk>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox