From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: Thu, 01 Nov 2018 11:10:14 -0400
Message-ID: <8871.1541085014@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoa9axjx4WkiFp+70E5rSsAwHE377O73jMZXCw1MRj3gNg@mail.gmail.com>
References: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql>
<12291633.PFnvXaAOpE@x200m>
<CA+Tgmoa9axjx4WkiFp+70E5rSsAwHE377O73jMZXCw1MRj3gNg@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 7, 2018 at 10:23 AM Nikolay Shaplov <dhyan@nataraj.su> wrote:
>>> I see you lost the Oxford comma:
>>>
>>> -DETAIL: Valid values are "on", "off", and "auto".
>>> +DETAIL: Valid values are "auto", "on" and "off".
>>>
>>> Please put these back.
>> Actually that's me who have lost it. The code with oxford comma would be a
>> bit more complicated. We should put such coma when we have 3+ items and do not
>> put it when we have 2.
>>
>> Does it worth it?
> In my opinion, it is worth it.
Uh ... I've not been paying attention to this thread, but this exchange
seems to be about somebody constructing a message like that piece-by-piece
in code. This has got to be a complete failure from the translatability
standpoint. See
https://www.postgresql.org/docs/devel/static/nls-programmer.html#NLS-GUIDELINES
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, alvherre@alvh.no-ip.org, n.gluhov@postgrespro.ru
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
In-Reply-To: <8871.1541085014@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox