From: Jürgen Purtz <juergen@purtz.de>
To: David G. Johnston <david.g.johnston@gmail.com>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add section headings to index types doc
Date: Fri, 23 Oct 2020 12:18:50 +0200
Message-ID: <8d0b636d-95e1-e802-fa8f-98708cc2d75b@purtz.de> (raw)
In-Reply-To: <CAKFQuwYEx+4qwrLJ0ne6vaJef1eurrvL2rv7TDcgcpfLOQA02Q@mail.gmail.com>
References: <877dukhvzg.fsf@wibble.ilmari.org>
<2268714.1596457003@sss.pgh.pa.us>
<159706393772.790.11301900224459454375.pgcf@coridan.postgresql.org>
<20200930063423.GG1996@paquier.xyz>
<87pn63ecc0.fsf@wibble.ilmari.org>
<CAKFQuwYEx+4qwrLJ0ne6vaJef1eurrvL2rv7TDcgcpfLOQA02Q@mail.gmail.com>
On 21.10.20 23:12, David G. Johnston wrote:
> On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker
> <ilmari@ilmari.org <mailto:ilmari@ilmari.org>> wrote:
>
> Michael Paquier <michael@paquier.xyz <mailto:michael@paquier.xyz>>
> writes:
>
> > On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote:
> >> The new status of this patch is: Waiting on Author
> >
> > This has not been answered yet, so I have marked the patch as
> returned
> > with feedback.
>
> Updated patch attached, wich reformats the operator lists as requested
> by Jürgen,
>
>
> A couple of things:
>
> One, I would place the equality operator for hash inside a standalone
> synopsis just like all of the others.
ok
> Two, why is hash special in having its create index command provided
> here? (I notice this isn't the fault of this patch but it stands out
> when reviewing it)
yes, this looks odd.
>
> I would suggest rewording hash to look more like the others
ok
> and add a link to the "CREATE INDEX" command from the chapter preamble.
is the link necessary?
>
> and skips the reindentation as suggested by Tom.
>
>
> Agreed
> David J.
--
J. Purtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: juergen@purtz.de, david.g.johnston@gmail.com, ilmari@ilmari.org, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Add section headings to index types doc
In-Reply-To: <8d0b636d-95e1-e802-fa8f-98708cc2d75b@purtz.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox