From: Sofia Kopikova <s.kopikova@postgrespro.ru>
To: Peter Eisentraut <peter@eisentraut.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
Date: Wed, 14 Aug 2024 13:14:48 +0300
Message-ID: <8ff5dbce-9eb2-4a22-b1dd-d6d387a5838c@postgrespro.ru> (raw)
In-Reply-To: <859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org>
References: <e0b17014-5319-4dd6-91cd-93d9c8fc9539@postgrespro.ru>
<CA+TgmoZ+NDotjPyVWrBJNZvv2XLYnHq3uVkpQRGe5WdaoHxt8A@mail.gmail.com>
<859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org>
On 8/14/24 12:50, Peter Eisentraut wrote:
> On 13.08.24 21:00, Robert Haas wrote:
>> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
>> <s.kopikova@postgrespro.ru> wrote:
>>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>>> header files. According to the commit message in 8ec569479, all
>>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>>
>>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>>
>> This seems correct to me.
>
> committed
>
Many thanks for quick review and commit.
--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: s.kopikova@postgrespro.ru, peter@eisentraut.org, robertmhaas@gmail.com
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
In-Reply-To: <8ff5dbce-9eb2-4a22-b1dd-d6d387a5838c@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox