From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Cramer <davecramer@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: Thu, 29 Jul 2021 17:01:24 -0400
Message-ID: <915981.1627592484@sss.pgh.pa.us> (raw)
In-Reply-To: <CADK3HHLZP=3HYNY_qsVBDQt83F7QpY_WrqXGN=KkQZCxraOyLA@mail.gmail.com>
References: <20210729163448.GP9600@momjian.us>
<202107291743.pqlj3s2uilfu@alvherre.pgsql>
<20210729190645.GS9600@momjian.us>
<CADK3HHLZP=3HYNY_qsVBDQt83F7QpY_WrqXGN=KkQZCxraOyLA@mail.gmail.com>
Dave Cramer <davecramer@gmail.com> writes:
> So back to the original motivation for bringing this up. Recall that a
> cluster was upgraded. Everything appeared to work fine, except that the
> definitions of the functions were slightly different enough to cause a
> fatal issue on restoring a dump from pg_dump.
> Since pg_upgrade is now part of the core project, we need to make sure this
> is not possible or be much more insistent that the user needs to upgrade
> any extensions that require it.
TBH, this seems like mostly the fault of the extension author.
The established design is that the SQL-level objects will be
carried forward verbatim by pg_upgrade. Therefore, any newer-version
shared library MUST be able to cope sanely with SQL objects from
some previous revision. The contrib modules provide multiple
examples of ways to do this.
If particular extension authors don't care to go to that much
trouble, it's on their heads to document that their extensions
are unsafe to pg_upgrade.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, davecramer@gmail.com, bruce@momjian.us, alvherre@alvh.no-ip.org, david.g.johnston@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
In-Reply-To: <915981.1627592484@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox