Re: Password identifiers, protocol aging and SCRAM protocol

pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: David Steele <david@pgmasters.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Fetter <david@fetter.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Julian Markwort <julian.markwort@uni-muenster.de>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Valery Popov <v.popov@postgrespro.ru>
Subject: Re: Password identifiers, protocol aging and SCRAM protocol
Date: Fri, 02 Sep 2016 09:59:23 -0400
Message-ID: <9194.1472824763@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqQzQnO11P_j1rEOzFjMRYNiDsAkzAbt111Srs-EONb9Zw@mail.gmail.com>
References: <CAB7nPqSL_V+0nD5i-XH_x1o5HTt2bT53vVwPUTHz8YT0hYRoPg@mail.gmail.com>
	<20160720181257.GA686053@alvherre.pgsql>
	<20160720202524.GA16111@fetter.org>
	<CAB7nPqQwR+93uLozt-CYiDnq1WPQYLYjZ5NMWs_3Pthu1pWFQQ@mail.gmail.com>
	<CA+TgmoZMn67CUgUxTD2vFgp7oHWH9qCHRUWebY6OSfSRVG5a_g@mail.gmail.com>
	<88f35221-2abd-6a31-a75d-28a3dc3a5b30@pgmasters.net>
	<29704.1469122290@sss.pgh.pa.us>
	<CAB7nPqRp74T70QELi8M8LHmMPXSzzBHwc3orAsQFuGbxB4o0HQ@mail.gmail.com>
	<19611.1469144923@sss.pgh.pa.us>
	<CAB7nPqRsUR09-eqmc5RVv8rvBk0nj4PctxL6YkKL73Tc47hSLg@mail.gmail.com>
	<20190.1469145748@sss.pgh.pa.us>
	<69938195-9c76-8523-0af8-eb718ea5b36e@iki.fi>
	<CAB7nPqRE3+5ptBRt2DpUP6WujofADGZ-Nc5nzZnhjQdUsE0p+Q@mail.gmail.com>
	<7fccb99f-8465-7ac8-72d5-3f41e90ae280@iki.fi>
	<CAB7nPqS9sWG5e6taBAo8O55rsptg-WL2-TAwVTzetiTicYdekw@mail.gmail.com>
	<47be24f5-12a5-7af8-efc0-9486a7dbd413@iki.fi>
	<CAB7nPqQzQnO11P_j1rEOzFjMRYNiDsAkzAbt111Srs-EONb9Zw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier <michael.paquier@gmail.com> writes:
> Before I send a new series of patches... There is one thing that I am
> still troubled with: the compilation of pgcrypto. First from
> contrib/pgcrypto/Makefile I am noticing the following issue with this
> block:
> CF_SRCS = $(if $(subst no,,$(with_openssl)), $(OSSL_SRCS), $(INT_SRCS))
> CF_TESTS = $(if $(subst no,,$(with_openssl)), $(OSSL_TESTS), $(INT_TESTS))
> CF_PGP_TESTS = $(if $(subst no,,$(with_zlib)), $(ZLIB_TST), $(ZLIB_OFF_TST))
> How is that correct if src/Makefile.global is not loaded first?
> Variables like with_openssl are still not loaded at that point.

Um, you do know that Make treats "=" definitions of variables as,
essentially, macro definitions?  The fact that with_openssl isn't
set yet doesn't necessarily mean these definitions are wrong.
Is it actually not working for you, or are you just not understanding
why it works?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

view thread (149+ messages)  latest in thread

Message-ID: <9194.1472824763@sss.pgh.pa.us>
Permalink:  ../9194.1472824763@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9194.1472824763@sss.pgh.pa.us

 ·

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, hlinnaka@iki.fi, david@pgmasters.net, robertmhaas@gmail.com, david@fetter.org, alvherre@2ndquadrant.com, magnus@hagander.net, peter.eisentraut@2ndquadrant.com, julian.markwort@uni-muenster.de, sfrost@snowman.net, v.popov@postgrespro.ru
  Subject: Re: Password identifiers, protocol aging and SCRAM protocol
  In-Reply-To: <9194.1472824763@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox