From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Витус Вагнер <vitus@wagner.pp.ru>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: Sun, 06 Jan 2019 15:42:20 +0300
Message-ID: <96675367.WEgyTzNvEp@x200m> (raw)
In-Reply-To: <364f4cb7-4f1f-516e-d27e-59578b7cf18c@2ndquadrant.com>
References: <2394207.ccz7JgCJsh@x200m>
<2205856.meAnofT0VS@x200m>
<364f4cb7-4f1f-516e-d27e-59578b7cf18c@2ndquadrant.com>
В письме от четверг, 3 января 2019 г. 12:52:36 MSK пользователь Peter
Eisentraut написал:
> >> +1, let's keep it simple. I would just use "ctags/etags not found"
> >> as error message.
> >
> > Actually I was trying to say "Please install 'ctags' [utility] to run
> > make_ctags". But if all of you read it as "Please install 'ctags'
> > [package] to run make_ctags", then it is really better to drop the
> > advice.
> >
> > So I removed it. See the patch.
>
> A few more comments.
>
> I don't know how portable command -v is. Some systems have a /bin/sh
> that is pre-POSIX. Same with $(...).
Do you know how to obtain such a shell in Debian? I have dash for sh, and it
knows both commands -v and $(). And I have no idea how to get more simple one.
Do you have one?
Do you know the way how to check if shell is pre-POSIX and just disable the
check in this case.
Or can you offer some another check that will satisfy you as a potential user
of pre-POSIX shell? The check that will somehow report that ctags _executable_
file is missing.
> If etags is not installed, the current script prints
>
> xargs: etags: No such file or directory
make_ctags prints
xargs: ctags: No such file or directory
sort: cannot read: tags: No such file or directory
For me it is not good enough error message, it says it can't find some ctags|
etags file. But says nothing that is is an utility, that is missing...
So I would try to find better way to report that ctags utility is missing.
PS Vitus, I added you to CC, because I know that you are quite good in bash
scripting, may be you would give some good ideas I do not have.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, vitus@wagner.pp.ru
Subject: Re: [PATCH] check for ctags utility in make_ctags
In-Reply-To: <96675367.WEgyTzNvEp@x200m>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox