public inbox for [email protected]
help / color / mirror / Atom feed[PATCH] Two small errhint cleanups in PG19 code
3+ messages / 3 participants
[nested] [flat]
* [PATCH] Two small errhint cleanups in PG19 code
@ 2026-05-25 02:38 Baji Shaik <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Baji Shaik @ 2026-05-25 02:38 UTC (permalink / raw)
To: [email protected]
Hi,
While exploring new features in PG19, I came across two unrelated
small errhint issues. Sending them as separate patches in one thread since
they touch
unrelated subsystems and can be reviewed/committed independently.
Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
The errhint in import_pg_statistic() reads:
Value of element "%s" must be type a null or a string.
The word "type" is a stray word that doesn't belong; the intent is
"must be a null or a string".
Patch 0002 -- Add missing period to online data checksums errhint
The errhint emitted when StartupXLOG() detects an interrupted
"enabling data checksums" run is missing a trailing period:
Data checksum processing must be manually restarted for
checksums to be enabled
Thanks,
Baji Shaik
Attachments:
[application/octet-stream] 0002-Add-missing-period-to-online-data-checksums-errhint.patch (1.1K, 3-0002-Add-missing-period-to-online-data-checksums-errhint.patch)
download | inline diff:
From 844ec1feafcd5d0be1eb3f2b6bc8c9d43f7f3751 Mon Sep 17 00:00:00 2001
From: Baji Shaik <[email protected]>
Date: Fri, 22 May 2026 11:47:45 -0500
Subject: [PATCH 2/2] Add missing period to online data checksums errhint
The errhint emitted when StartupXLOG() detects an interrupted
"enabling data checksums" run is missing a trailing period:
Data checksum processing must be manually restarted for checksums
to be enabled
Add the missing period.
---
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index beddcb552d6..fecdf0d4b05 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6612,7 +6612,7 @@ StartupXLOG(void)
ereport(WARNING,
errmsg("enabling data checksums was interrupted"),
- errhint("Data checksum processing must be manually restarted for checksums to be enabled"));
+ errhint("Data checksum processing must be manually restarted for checksums to be enabled."));
}
/*
--
2.50.1 (Apple Git-155)
[application/octet-stream] 0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch (1.3K, 4-0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch)
download | inline diff:
From 7b672aeb73da477cf66aad72a5f1dd3ecc52f355 Mon Sep 17 00:00:00 2001
From: Baji Shaik <[email protected]>
Date: Fri, 22 May 2026 11:47:33 -0500
Subject: [PATCH 1/2] Remove stray word in pg_restore_extended_stats() errhint
The errhint message in import_pg_statistic() reads:
Value of element "%s" must be type a null or a string.
The word "type" is a stray word that doesn't belong; the intent is
"must be a null or a string". Reword to:
Value of element "%s" must be a null or a string.
---
src/backend/statistics/extended_stats_funcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/statistics/extended_stats_funcs.c b/src/backend/statistics/extended_stats_funcs.c
index ab748068225..4a65a46df41 100644
--- a/src/backend/statistics/extended_stats_funcs.c
+++ b/src/backend/statistics/extended_stats_funcs.c
@@ -1160,7 +1160,7 @@ import_pg_statistic(Relation pgsd, JsonbContainer *cont,
ereport(WARNING,
errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("could not parse \"%s\": invalid element in expression %d", argname, exprnum),
- errhint("Value of element \"%s\" must be type a null or a string.", s));
+ errhint("Value of element \"%s\" must be a null or a string.", s));
goto pg_statistic_error;
}
}
--
2.50.1 (Apple Git-155)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Two small errhint cleanups in PG19 code
@ 2026-05-25 05:38 Chao Li <[email protected]>
parent: Baji Shaik <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Chao Li @ 2026-05-25 05:38 UTC (permalink / raw)
To: Baji Shaik <[email protected]>; +Cc: [email protected]
> On May 25, 2026, at 10:38, Baji Shaik <[email protected]> wrote:
>
> Hi,
>
> While exploring new features in PG19, I came across two unrelated
> small errhint issues. Sending them as separate patches in one thread since they touch
> unrelated subsystems and can be reviewed/committed independently.
>
> Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
> The errhint in import_pg_statistic() reads:
>
> Value of element "%s" must be type a null or a string.
>
> The word "type" is a stray word that doesn't belong; the intent is
> "must be a null or a string".
Agreed.
>
> Patch 0002 -- Add missing period to online data checksums errhint
> The errhint emitted when StartupXLOG() detects an interrupted
> "enabling data checksums" run is missing a trailing period:
>
> Data checksum processing must be manually restarted for
> checksums to be enabled
>
Yes, a hint message should end with a period.
> Thanks,
> Baji Shaik
> <0002-Add-missing-period-to-online-data-checksums-errhint.patch><0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch>
So, both changes look good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH] Two small errhint cleanups in PG19 code
@ 2026-05-25 06:05 Michael Paquier <[email protected]>
parent: Chao Li <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2026-05-25 06:05 UTC (permalink / raw)
To: Chao Li <[email protected]>; +Cc: Baji Shaik <[email protected]>; [email protected]
On Mon, May 25, 2026 at 01:38:26PM +0800, Chao Li wrote:
> So, both changes look good to me.
Aye. One of them is on me but I'll just grab the second one while on
it. You forgot to update the regression test outputs, at quick
glance, but no need to send an updated patch.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-05-25 06:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-25 02:38 [PATCH] Two small errhint cleanups in PG19 code Baji Shaik <[email protected]>
2026-05-25 05:38 ` Chao Li <[email protected]>
2026-05-25 06:05 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox