public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fujii Masao <[email protected]>
To: Chao Li <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Rafia Sabih <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Set notice receiver before libpq connection startup
Date: Thu, 28 May 2026 14:22:21 +0900
Message-ID: <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
<[email protected]>
<CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
<[email protected]>
<CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
<CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
<[email protected]>
<CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
On Thu, May 28, 2026 at 9:40 AM Chao Li <[email protected]> wrote:
> > The committed patch violates the .gitattributes whitespace rules:
> >
> > git show --check 06a5c3cdef02
> >
> > contrib/postgres_fdw/connection.c:651: indent with spaces.
> > + /* expand_dbname = */ false);
> >
> > It is unfortunate that pgindent produces this layout that contradicts the git configuration. (The current formatting also doesn't look like what I would produce in an editor, so I think git is right here.)
> >
> > Maybe we could reformat this slightly to avoid that? (unless someone wants to try to fix pgindent)
Thanks for the report!
> Ah, I was not aware of the whitespace rule. I think it was not pgindent; I made that change manually. I added “=” because I thought it might read more fluently.
>
> Attached is a fix for that.
Thanks for the patch!
I suspect the whitespace issue was caused by pgindent that I ran
before committing the patch.
- /* expand_dbname = */ false);
+ false /* expand_dbname */ );
I think "/* expand_dbname = */ false" looks better. libpqwalreceiver.c
also uses that comment style. So how about the attached v2 patch, which
reformats the comment accordingly?
After applying the v2 patch, I confirmed that neither "git show --check ..."
nor pgindent reports any issues.
Regards,
--
Fujii Masao
Attachments:
[application/octet-stream] v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch (1.3K, 2-v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch)
download | inline diff:
From 82c5e9061c2e7e54180d5af17c3993816a7322f1 Mon Sep 17 00:00:00 2001
From: "Chao Li (Evan)" <[email protected]>
Date: Thu, 28 May 2026 08:30:22 +0800
Subject: [PATCH v2] Fix an indentation problem in postgres_fdw/connection.c
Reported-by: Peter Eisentraut <[email protected]>
Author: Chao Li <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/[email protected]
---
contrib/postgres_fdw/connection.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
index 346f6f1fbfe..aab21695979 100644
--- a/contrib/postgres_fdw/connection.c
+++ b/contrib/postgres_fdw/connection.c
@@ -647,8 +647,9 @@ connect_pg_server(ForeignServer *server, UserMapping *user)
pgfdw_we_connect = WaitEventExtensionNew("PostgresFdwConnect");
/* OK to make connection */
- start_conn = libpqsrv_connect_params_start(keywords, values,
- /* expand_dbname = */ false);
+ start_conn =
+ libpqsrv_connect_params_start(keywords, values,
+ /* expand_dbname = */ false);
PQsetNoticeReceiver(start_conn, libpqsrv_notice_receiver,
"received message via remote connection");
libpqsrv_connect_complete(start_conn, pgfdw_we_connect);
--
2.53.0
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Set notice receiver before libpq connection startup
In-Reply-To: <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox