public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Smith <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Vitaly Davydov <[email protected]>
Cc: Ajin Cherian <[email protected]>
Subject: Re: Slow catchup of 2PC (twophase) transactions on replica in LR
Date: Wed, 17 Jul 2024 14:28:20 +1000
Message-ID: <CAHut+Pv-up=MFqYXSVzCszdxU-n2kdcs3asbrAiKn4_z0VdrrA@mail.gmail.com> (raw)
In-Reply-To: <TYCPR01MB56938F06B84DD92A88234667F5A22@TYCPR01MB5693.jpnprd01.prod.outlook.com>
References: <OSBPR01MB255215A39F66932323295854F5DB2@OSBPR01MB2552.jpnprd01.prod.outlook.com>
<CAA4eK1LOVQ+Qt-FEZPKaPPpggrPrE3AsFXkctp0tDm7CRcHt5Q@mail.gmail.com>
<TYCPR01MB56938F06B84DD92A88234667F5A22@TYCPR01MB5693.jpnprd01.prod.outlook.com>
Hi, here is my review of the v18-0003 patch.
======
sgml/ref/alter_subscription.sgml
nitpick - some minor tweaks to the documentation text. I also added a link
back to the two_phase parameter. Please see the attached diffs file.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e021f87..58db97f 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -256,14 +256,15 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
</para>
<para>
- The <literal>two_phase</literal> parameter can only be altered when the
- subscription is disabled. When altering the parameter from <literal>true</literal>
+ The <link linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ parameter can only be altered when the subscription is disabled.
+ When altering the parameter from <literal>true</literal>
to <literal>false</literal>, the backend process checks for any incomplete
prepared transactions done by the logical replication worker (from when
<literal>two_phase</literal> parameter was still <literal>true</literal>)
- and, if any are found, this command is failed with an error. In this
- case, you can resolve prepared transactions on the publisher node or
- manually roll back them on the subscriber. After the altering from
+ and, if any are found, an error is reported. If this happens, you can
+ resolve prepared transactions on the publisher node or
+ manually roll back them on the subscriber, then try again. After the altering from
<literal>true</literal> to <literal>false</literal>, the publisher will
replicate transactions again when they are committed.
</para>
Attachments:
[text/plain] PS_NITPICKS_20240717_2PC_V180003.txt (1.6K, ../CAHut+Pv-up=MFqYXSVzCszdxU-n2kdcs3asbrAiKn4_z0VdrrA@mail.gmail.com/3-PS_NITPICKS_20240717_2PC_V180003.txt)
download | inline diff:
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e021f87..58db97f 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -256,14 +256,15 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
</para>
<para>
- The <literal>two_phase</literal> parameter can only be altered when the
- subscription is disabled. When altering the parameter from <literal>true</literal>
+ The <link linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ parameter can only be altered when the subscription is disabled.
+ When altering the parameter from <literal>true</literal>
to <literal>false</literal>, the backend process checks for any incomplete
prepared transactions done by the logical replication worker (from when
<literal>two_phase</literal> parameter was still <literal>true</literal>)
- and, if any are found, this command is failed with an error. In this
- case, you can resolve prepared transactions on the publisher node or
- manually roll back them on the subscriber. After the altering from
+ and, if any are found, an error is reported. If this happens, you can
+ resolve prepared transactions on the publisher node or
+ manually roll back them on the subscriber, then try again. After the altering from
<literal>true</literal> to <literal>false</literal>, the publisher will
replicate transactions again when they are committed.
</para>
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Slow catchup of 2PC (twophase) transactions on replica in LR
In-Reply-To: <CAHut+Pv-up=MFqYXSVzCszdxU-n2kdcs3asbrAiKn4_z0VdrrA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox