public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Smith <[email protected]>
To: vignesh C <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
Date: Mon, 13 Apr 2026 15:23:48 +1000
Message-ID: <CAHut+PvAaCXaTthFJOKNTaygAzrUVaoKFcnq+kMXnWbBpoHWtA@mail.gmail.com> (raw)
In-Reply-To: <CALDaNm3nucvcX_-jU-YqX2k4dTM_qY72gFbh10SnWp4gro+ifQ@mail.gmail.com>
References: <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>
<CAA4eK1KUP5h++hSK6eo--jx=jRJ2TTPqYYmOg=7anCm=__S_0w@mail.gmail.com>
<CAHut+PvtmM7tCut-K-EWSq0_Hg5ey=M2NreU_Fq80SpUOgmiBw@mail.gmail.com>
<CALDaNm3nucvcX_-jU-YqX2k4dTM_qY72gFbh10SnWp4gro+ifQ@mail.gmail.com>
On Mon, Apr 13, 2026 at 1:21 PM vignesh C <[email protected]> wrote:
>
...
> The commit message could be improved:
> Date: Mon, 13 Apr 2026 12:12:00 +1000
> Subject: [PATCH v1] describe table except publications
>
> ---
> src/bin/psql/describe.c | 2 +-
>
> Other than that, the patch looks good to me.
>
Hi Vignesh.
Thanks for the review.
PSA patch v2. It is the same as v1, but with an improved commit message,
======
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachments:
[application/octet-stream] v2-0001-describe-table-except-publications.patch (2.2K, 2-v2-0001-describe-table-except-publications.patch)
download | inline diff:
From 5a8a649d2eb673460bce86a80d0ff63a4c7fcfc6 Mon Sep 17 00:00:00 2001
From: Peter Smith <[email protected]>
Date: Mon, 13 Apr 2026 14:56:31 +1000
Subject: [PATCH v2] describe table except publications
Commit fd36606 introduced a small "case" inconsistency in the psql table
describe (\d) command output. "Except Publications:" should say "Except
publications:".
Author: Peter Smith <[email protected]>
Reviewed-by: vignesh C <[email protected]>
Discussion: https://www.postgresql.org/message-id/CAHut%2BPvtmM7tCut-K-EWSq0_Hg5ey%3DM2NreU_Fq80SpUOgmiBw%40mail.gmail.com
---
src/bin/psql/describe.c | 2 +-
src/test/regress/expected/publication.out | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 4e8ff00394a..291c493f594 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -3306,7 +3306,7 @@ describeOneTableDetails(const char *schemaname,
tuples = PQntuples(result);
if (tuples > 0)
- printTableAddFooter(&cont, _("Except Publications:"));
+ printTableAddFooter(&cont, _("Except publications:"));
/* Might be an empty set - that's ok */
for (i = 0; i < tuples; i++)
diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out
index a9059a39138..d028e9be866 100644
--- a/src/test/regress/expected/publication.out
+++ b/src/test/regress/expected/publication.out
@@ -252,7 +252,7 @@ Indexes:
"testpub_tbl1_pkey" PRIMARY KEY, btree (id)
Publications:
"testpub_foralltables"
-Except Publications:
+Except publications:
"testpub_foralltables_excepttable"
"testpub_foralltables_excepttable1"
@@ -435,7 +435,7 @@ Except tables:
--------+---------+-----------+----------+---------
a | integer | | |
Partition of: testpub_root FOR VALUES FROM (0) TO (100)
-Except Publications:
+Except publications:
"testpub8"
\d testpub_root
@@ -444,7 +444,7 @@ Except Publications:
--------+---------+-----------+----------+---------
a | integer | | |
Partition key: RANGE (a)
-Except Publications:
+Except publications:
"testpub8"
Number of partitions: 1 (Use \d+ to list them.)
--
2.47.3
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
In-Reply-To: <CAHut+PvAaCXaTthFJOKNTaygAzrUVaoKFcnq+kMXnWbBpoHWtA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox