pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: RE: Improve logging when using Huge Pages
Date: Fri, 4 Nov 2022 10:48:57 +0000
Message-ID: <DM4PR84MB1734A6EE5103AB67F5F3B9F4EE3B9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CA+hUKGJCZaeJX+z-qNnkgMW2B0FiqxfmaT7ALj7GwMRtNjjLog@mail.gmail.com>
References: <TU4PR8401MB1152B1A4158D609472ABD51DEEA09@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<80872660-ad16-3040-0a25-bd741faa5fc0@oss.nttdata.com>
	<20210922002322.GS831@telsasoft.com>
	<20210927.114023.1519840069762071193.horikyota.ntt@gmail.com>
	<TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<20211022023815.GI741@telsasoft.com>
	<TU4PR8401MB11529CCEE0FCC07EEE9F8FA7EE859@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<20211028220534.GB31568@telsasoft.com>
	<d928cc86-8e03-b481-18f7-2cb9c28fc724@oss.nttdata.com>
	<CAD21AoDrEma7ZGid2siYMDSa559O3Ox+N_D2B6vGwN5opqYr1w@mail.gmail.com>
	<TU4PR8401MB1152ECB9368A5CCC9AB0835DEE9F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<d0a35f68-5d13-306c-f589-0ce816e952a5@timescale.com>
	<DM4PR84MB1734812E1690CD7BEB4B9C57EE9C9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
	<CA+hUKGJCZaeJX+z-qNnkgMW2B0FiqxfmaT7ALj7GwMRtNjjLog@mail.gmail.com>

Thanks for your comment. 
I understand that some people don't like noise log. However, I don't understand the feeling of disliking the one-line log that is output when the instance is started. 
In both MySQL and Oracle Database, a log is output if it fails to acquire HugePages with the same behavior as huge_pages=try in PostgreSQL.

Regards,
Noriyoshi Shinoda


-----Original Message-----
From: Thomas Munro <thomas.munro@gmail.com> 
Sent: Thursday, November 3, 2022 10:10 AM
To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
Cc: Jacob Champion <jchampion@timescale.com>; Masahiko Sawada <sawada.mshk@gmail.com>; Fujii Masao <masao.fujii@oss.nttdata.com>; Justin Pryzby <pryzby@telsasoft.com>; PostgreSQL-development <pgsql-hackers@postgresql.org>; Julien Rouhaud <rjuju123@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Improve logging when using Huge Pages

On Wed, Aug 3, 2022 at 8:42 PM Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com> wrote:
> > As discussed in [1], we're taking this opportunity to return some patchsets that don't appear to be getting enough reviewer interest.
> Thank you for your helpful comments.
> As you say, my patch doesn't seem to be of much interest to reviewers either.
> I will discard the patch I proposed this time and consider it again.

I wonder if the problem here is that people are reluctant to add noise
to every starting system.   There are people who have not configured
their system and don't want to see that noise, and then some people have configured their system and would like to know about it if it doesn't work so they can be aware of that, but don't want to use "off"
because they don't want a hard failure.  Would it be better if there were a new level "try_log" (or something), which only logs a message if it tries and fails?


view thread (93+ messages)  latest in thread

Message-ID: <DM4PR84MB1734A6EE5103AB67F5F3B9F4EE3B9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>
Permalink:  ../DM4PR84MB1734A6EE5103AB67F5F3B9F4EE3B9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM/
Also on:    postgresql.org/message-id/DM4PR84MB1734A6EE5103AB67F5F3B9F4EE3B9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: noriyoshi.shinoda@hpe.com, thomas.munro@gmail.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, rjuju123@gmail.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com
  Subject: RE: Improve logging when using Huge Pages
  In-Reply-To: <DM4PR84MB1734A6EE5103AB67F5F3B9F4EE3B9@DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox