public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
Date: Wed, 11 Jan 2023 15:49:44 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
	<Y41H/[email protected]>
	<CALDaNm3s0MHr1iw716JsacmA4yyCFn4tCw1=3c6Sm2xjvBVYDA@mail.gmail.com>
	<[email protected]>

On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> It suggests the *kinds* of objects that are part of the extension, but
> lists the objects of that kind regardless of dependency.  I read
> Michael suggested (and I agree) to restrict the objects (not kinds) to
> actually be a part of the extension. (And not for object kinds.)

Yeah, that's what I meant.  Now, if Vignesh does not want to extend
that, that's fine for me as well at the end on second thought, as this 
involves much more code for each DROP path depending on the object
type involved.

Adding the object names after DROP/ADD is useful on its own, and we
already have some completion once the object type is specified, so
simpler is perhaps just better here.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox