From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dgrowleyml@gmail.com
Cc: alvherre@alvh.no-ip.org
Cc: bharath.rupireddyforpostgres@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
Date: Tue, 27 Jul 2021 10:47:54 +0900
Message-ID: <YP9lygRhftW7U2lE@paquier.xyz> (raw)
In-Reply-To: <20210726.174622.826565852378770261.horikyota.ntt@gmail.com>
References: <YPkC828cQ8SMkMjI@paquier.xyz>
<YPvuSPBaAcq2txqF@paquier.xyz>
<YP5Pv0d13Ct+03ve@paquier.xyz>
<20210726.174622.826565852378770261.horikyota.ntt@gmail.com>
On Mon, Jul 26, 2021 at 05:46:22PM +0900, Kyotaro Horiguchi wrote:
> Thanks for revising and committing! I'm fine with all of the recent
> discussions on the committed part. Though I don't think it works for
> "live" command line options, making the omitting policy symmetric
> looks good. I see the same done in several similar use of strto[il].
OK, applied this one. So for now we are done here.
> The change in 020_pg_receivewal.pl results in a chain of four
> successive failures, which is fine. But the last failure (#23) happens
> for a bit dubious reason.
Yes, I saw that as well. I'll address that separately.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../YP9lygRhftW7U2lE@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
In-Reply-To: <YP9lygRhftW7U2lE@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox