pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
Date: Sat, 24 Jul 2021 19:41:12 +0900
Message-ID: <YPvuSPBaAcq2txqF@paquier.xyz> (raw)
In-Reply-To: <YPkC828cQ8SMkMjI@paquier.xyz>
References: <20210714.103556.2157482390190763832.horikyota.ntt@gmail.com>
	<202107141502.hmecfak3hd2y@alvherre.pgsql>
	<YO/ha9QvyUsz7mJ6@paquier.xyz>
	<20210721.170229.1864410878946243716.horikyota.ntt@gmail.com>
	<YPgJ2Xo45hx8f4Id@paquier.xyz>
	<CAApHDvoEe2j33+6=ZyV4w2adgQXKGdyvrj2+eyf0NzH0K3boMw@mail.gmail.com>
	<YPgWpvro0ZLjP03N@paquier.xyz>
	<CAApHDvoBw_Kk0XGOJwshnwq68gMn7aZPKgPMzWv5s+ddzhpCog@mail.gmail.com>
	<YPkC828cQ8SMkMjI@paquier.xyz>

On Thu, Jul 22, 2021 at 02:32:35PM +0900, Michael Paquier wrote:
> Okay, done those parts as per the attached.  While on it, I noticed an
> extra one for pg_dump --rows-per-insert.  I am counting 25 translated
> strings cut in total.
> 
> Any objections to this first step?

I have looked at that over the last couple of days, and applied it
after some small fixes, including an indentation.  The int64 and float
parts are extra types we could handle, but I have not looked yet at
how much benefits we'd get in those cases.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../YPvuSPBaAcq2txqF@paquier.xyz/2-signature.asc)
  download

view thread (26+ messages)  latest in thread

Message-ID: <YPvuSPBaAcq2txqF@paquier.xyz>
Permalink:  ../YPvuSPBaAcq2txqF@paquier.xyz/
Also on:    postgresql.org/message-id/YPvuSPBaAcq2txqF@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, dgrowleyml@gmail.com, horikyota.ntt@gmail.com, alvherre@alvh.no-ip.org, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
  In-Reply-To: <YPvuSPBaAcq2txqF@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox