From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: enable certain TAP tests for MSVC builds
Date: Wed, 8 Dec 2021 17:14:14 +0900
Message-ID: <YbBpViH/EIJ2ZgBO@paquier.xyz> (raw)
In-Reply-To: <9461cfff-5685-b46b-ac2e-17a67c59c836@dunslane.net>
References: <17093da5-e40d-8335-d53a-2bd803fc38b0@dunslane.net>
<20211205194755.GA1974806@rfd.leadboat.com>
<4cea538c-def4-3f3e-7980-95497c33980e@dunslane.net>
<20211205233238.GB1974806@rfd.leadboat.com>
<9461cfff-5685-b46b-ac2e-17a67c59c836@dunslane.net>
On Tue, Dec 07, 2021 at 03:40:29PM -0500, Andrew Dunstan wrote:
> All done.
bowerbird is complaining here with the tests of pg_basebackup:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-12-08%2004%3A52%3A27
tar: Cannot execute remote shell: No such file or directory
tar: H\\:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_basebackup/tmp_check/t_010_pg_basebackup_main_data/backup/tarbackup2/base.tar:
Cannot open: I/O error
tar: Error is not recoverable: exiting now
This comes from init_from_backup() via the tar_command. I am not sure
what to think about this error. Perhaps this is related to the
environment.
+$ENV{TAR} ||= 'tar';
+$ENV{LZ4} ||= 'lz4';
+$ENV{GZIP_PROGRAM} ||= 'gzip';
This means that the default is to assume that those commands will be
always present, no? But that may not be the case, which would cause
the tests of pg_basebackup to fail in 010_pg_basebackup.pl. Shouldn't
we at least check that the command can be executed if defined and skip
the tests if not, in the same fashion as LZ4 and GZIP?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andrew@dunslane.net, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: enable certain TAP tests for MSVC builds
In-Reply-To: <YbBpViH/EIJ2ZgBO@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox