From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
Date: Mon, 23 May 2022 08:53:24 +0900
Message-ID: <YorM9Kv4bFVBoCsI@paquier.xyz> (raw)
In-Reply-To: <20220522202608.GA892371@nathanxps13>
References: <CAB8KJ=jhPyYFu-A5r-ZGP+Ax715mUKsMxAGcEQ9Cx_mBAmrPow@mail.gmail.com>
<20220520230837.GB877934@nathanxps13>
<YohcelRv74nuHC9Z@paquier.xyz>
<20220521185743.GA886636@nathanxps13>
<YomLAynQiordq3lg@paquier.xyz>
<20220522202608.GA892371@nathanxps13>
On Sun, May 22, 2022 at 01:26:08PM -0700, Nathan Bossart wrote:
> Yeah, this crossed my mind. I thought that "superusers, roles with
> privileges of the pg_read_all_stats_role, roles with privileges of the user
> owning the session being reported on, and the user owning the session being
> reported on" might be too long-winded and redundant. But I see your point
> that it might be a bit confusing. Perhaps it could be trimmed down to
> something like this:
>
> ... superusers, roles with privileges of the pg_read_all_stats role,
> and roles with privileges of the user owning the session being reported
> on (including the session owner).
Yeah, that sounds better to me. monitoring.sgml has a different way
of wording what looks like the same thing for pg_stat_xact_*_tables:
"Ordinary users can only see all the information about their own
sessions (sessions belonging to a role that they are a member of)".
So you could say instead something like: this information is only
visible to superusers, roles with privileges of the pg_read_all_stats
role, and the user owning the sessionS being reported on (including
sessions belonging to a role that they are a member of).
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, barwick@gmail.com
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
In-Reply-To: <YorM9Kv4bFVBoCsI@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox