From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: nagata@sraoss.co.jp
Cc: peter@eisentraut.org
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Tue, 26 Nov 2024 14:04:15 -0500
Message-ID: <Z0Ybr9iRBkOUYOGZ@momjian.us> (raw)
In-Reply-To: <1689262.1732642897@sss.pgh.pa.us>
References: <20241119112907.1cdfe086df16e7ac173f9571@sraoss.co.jp>
<ZzwA_DayripquW7e@momjian.us>
<20241119193121.7ba727c489b5f0b6d20f9c25@sraoss.co.jp>
<20241126.182513.1752581942460106099.ishii@postgresql.org>
<Z0X5xYJ_dvkREogb@momjian.us>
<1682864.1732639382@sss.pgh.pa.us>
<Z0YApkVlEfHYOaC4@momjian.us>
<1689262.1732642897@sss.pgh.pa.us>
On Tue, Nov 26, 2024 at 12:41:37PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote:
> >> I don't think this patch is doing anything I want at all.
>
> > Gee, I kind of liked the patch, but maybe you didn't like the additional
> > complexity to check the PDF output twice, once on input (complex) and
> > once on output. The attached patch only does the output check.
>
> It's still not doing anything I want at all. I'm with Tatsuo
> on this: I do not want the makefiles deciding for me which
> warnings are acceptable.
Okay, how about the attached patch that just prints the message at the
bottom, with no error. We could do this for all warnings, but I think
there are some we expect.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Attachments:latin1.diff (text/x-diff, 625B) downloaddiff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefileindex a04c532b536..cffb06317f9 100644--- a/doc/src/sgml/Makefile+++ b/doc/src/sgml/Makefile@@ -156,7 +156,9 @@ XSLTPROC_FO_FLAGS += --stringparam img.src.path '$(srcdir)/'
$(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_FO_FLAGS) --stringparam paper.type USletter -o $@ $^
%.pdf: %.fo $(ALL_IMAGES)
- $(FOP) -fo $< -pdf $@+ LANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \+ awk 'BEGIN { warn = 0 } { print } /not available in font/ { warn = 1 } \+ END { if (warn != 0) print("\nFound characters that cannot be displayed in the PDF document") }' 1>&2
##
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, ishii@postgresql.org, nagata@sraoss.co.jp, peter@eisentraut.org, daniel@yesql.se
Subject: Re: Doc: typo in config.sgml
In-Reply-To: <Z0Ybr9iRBkOUYOGZ@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox