From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Euler Taveira <euler.taveira@enterprisedb.com>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: Tue, 21 Jan 2025 15:39:51 +0900
Message-ID: <Z49BN3ger3nSL57v@paquier.xyz> (raw)
In-Reply-To: <3259117.1737424962@sss.pgh.pa.us>
References: <CAHut+PvYsVhF5k-mYHVEFdpijdgkYRtoeWVxdspxio0ePRpkug@mail.gmail.com>
<87pllx5cqn.fsf@wibble.ilmari.org>
<87msh159c3.fsf@wibble.ilmari.org>
<CAHut+Ptmusd=7SdZ-n0=fu-Y8ut=UaK9nU4Cqk01wxOmio9nkA@mail.gmail.com>
<87o70143p6.fsf@wibble.ilmari.org>
<3b6b2595-9822-4e4f-91ee-b6a44dc4b542@app.fastmail.com>
<3238498.1737413396@sss.pgh.pa.us>
<0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com>
<87ikq93qqa.fsf@wibble.ilmari.org>
<3259117.1737424962@sss.pgh.pa.us>
On Mon, Jan 20, 2025 at 09:02:42PM -0500, Tom Lane wrote:
> Nah, I'm pretty much -1 on bumping our perltidy version frequently.
> That imposes costs on every developer who wants to track it.
> It's unlikely that anyone will be on a platform that updates it
> exactly when we decide to change, so most of us are going to be
> using hand-installed copies that will have to be hand-updated
> whenever we change versions.
>
> As a data point, we were using 20170521 for five years before
> adopting 20230309, and 20090616 for seven years before that,
> which is as far back as I can trace any definitive info about
> which version was being used. Every five years or so sounds
> like a sane cadence to me, in terms of developer overhead
> versus likely formatting improvements.
>
> (Of course, if a new version comes out that is way better than
> what we're using, I could be persuaded that it's worth changing.
> But from what you're showing here, that hasn't happened yet.)
Using 20250105 would have the benefit to not have to use a custom
version when using the top of Debian, at least, until it is replaced
by its next release. I don't know how many committers use perltidy
before pushing changes, TBH. I do because it is integrated in my
scripts as a step I take before pushing anything, and I periodically
see diffs because we don't enforce a strict policy contrary to the C
code. Just my word for saying that I would not be against bumping it
its latest 2025 now, and that I'd be OK to be more aggressive
regarding such tooling upgrades.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, ilmari@ilmari.org, euler@eulerto.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org, peter@eisentraut.org, euler.taveira@enterprisedb.com
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
In-Reply-To: <Z49BN3ger3nSL57v@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox