pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Andy Fan <zhihuifan1213@163.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: convert libpgport's pqsignal() to a void function
Date: Thu, 16 Jan 2025 21:03:43 -0600
Message-ID: <Z4nIj9vqcTRFClKs@nathan> (raw)
In-Reply-To: <CA+hUKGJ=vvZQJ71NLHc_KJPWU2PFY6yzjsvyxHMFZd0wuGv3iw@mail.gmail.com>
References: <Z4chOKfnthRH71mw@nathan>
	<1164438.1736910166@sss.pgh.pa.us>
	<Z4cyRX-hqfXREYKC@nathan>
	<1171432.1736914085@sss.pgh.pa.us>
	<Z4gJTtG4ZX9vXl-y@nathan>
	<CA+hUKGL0NyB03uKrNqN0z1M=cwju_b_RJLgxtVPU4f0h8-8sZg@mail.gmail.com>
	<Z4gQxiLQrf5OLf18@nathan>
	<CA+hUKG+grkc4+e9EtegZcBn9oyTxUCEE9CFZvuPtvsXTuW=A=A@mail.gmail.com>
	<Z4hJJwITseaKq_81@nathan>
	<CA+hUKGJ=vvZQJ71NLHc_KJPWU2PFY6yzjsvyxHMFZd0wuGv3iw@mail.gmail.com>

I've now committed all of this.  I ended up finding a couple other frontend
programs that called pqsignal() with an invalid signal number on Windows,
so I fixed those as well.  AFAICT the reason I didn't catch them in my
earlier testing is because they aren't tested!  I'll keep an eye on the
buildfarm for any problems with the SIG_* redefinition removal, too.

Thanks for reviewing and for sharing lots of context about this stuff.

-- 
nathan





view thread (12+ messages)

Message-ID: <Z4nIj9vqcTRFClKs@nathan>
Permalink:  ../Z4nIj9vqcTRFClKs@nathan/
Also on:    postgresql.org/message-id/Z4nIj9vqcTRFClKs@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, zhihuifan1213@163.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: convert libpgport's pqsignal() to a void function
  In-Reply-To: <Z4nIj9vqcTRFClKs@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox