From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Andy Fan <zhihuifan1213@163.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: convert libpgport's pqsignal() to a void function
Date: Tue, 14 Jan 2025 21:57:57 -0600
Message-ID: <Z4cyRX-hqfXREYKC@nathan> (raw)
In-Reply-To: <1164438.1736910166@sss.pgh.pa.us>
References: <Z4chOKfnthRH71mw@nathan>
<1164438.1736910166@sss.pgh.pa.us>
On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote:
> LGTM, although I don't know enough about Windows to know if the
> "== SIG_ERR" test in that path is correct.
It's apparently not [0]. :(
My guess is that this has something to do with redefining SIG_ERR in
win32_port.h. We might be able to use push_macro/pop_macro to keep the old
value around, but at the moment I'm leaning towards just removing the
assertion in that path.
[0] https://cirrus-ci.com/task/6237809813487616
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, zhihuifan1213@163.com, pgsql-hackers@lists.postgresql.org
Subject: Re: convert libpgport's pqsignal() to a void function
In-Reply-To: <Z4cyRX-hqfXREYKC@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox