From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: longfin missing gssapi_ext.h
Date: Sat, 8 Apr 2023 07:43:38 -0400
Message-ID: <ZDFTailRZzyGdbXl@tamriel.snowman.net> (raw)
In-Reply-To: <3311389.1680927614@sss.pgh.pa.us>
References: <ZDDO6jaESKaBgej0@tamriel.snowman.net>
<3282942.1680920692@sss.pgh.pa.us>
<ZDDRNbHzkdQNBdpZ@tamriel.snowman.net>
<3284314.1680921096@sss.pgh.pa.us>
<ZDDSriHdl6+LwVl6@tamriel.snowman.net>
<ZDDTqZjoWdR/woAC@tamriel.snowman.net>
<3286097.1680922218@sss.pgh.pa.us>
<ZDDaGFCt5pZMG5Sw@tamriel.snowman.net>
<3311389.1680927614@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > I'm open to considering support for older versions, however ...
>
> NetBSD 9.3, which is their *latest production release*, doesn't have
> gssapi_ext.h [1]. For that matter, it doesn't look like their
> not-yet-released 10.0BETA does either (my NetBSD 10 animals would
> be failing if they had --with-gssapi). I do not think it's going
> to be acceptable to require this feature.
I'm certainly curious to understand what Kerberos library they're using
and how they're maintaining it. At least some of the documentation I've
found seems to indicate that it might be Heimdal, which does have
gss_store_cred_into in gssapi.h.
> I'm now going to reiterate my opinion that this patch should not
> have been pushed in at this point of the dev cycle. A month ago,
> there was time to deal with these sorts of issues.
I suspected there would be an issue with OSX but hadn't expected an
issue with NetBSD. I had tested this across a few Linux platforms and
cfbot showed it wasn't causing issues on Windows or the platforms that
are run there. Would be really great to have a way to test these things
out on these other platforms other than just committing them and seeing
what happens on the buildfarm.
In any case, I've reverted it and we can pick this up for the next
cycle. I'll play around with Heimdal locally as it appears to be
available on Ubuntu (I had actually thought Heimdal to be mostly gone at
this point since it only ever existed really due to silly export
restrictions...) and see if there's actually anything other than making
gssapi_ext.h itself be optional to be pulled in that's needed to make it
work.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us
Subject: Re: longfin missing gssapi_ext.h
In-Reply-To: <ZDFTailRZzyGdbXl@tamriel.snowman.net>
References: <ZDDO6jaESKaBgej0@tamriel.snowman.net> <3282942.1680920692@sss.pgh.pa.us> <ZDDRNbHzkdQNBdpZ@tamriel.snowman.net> <3284314.1680921096@sss.pgh.pa.us> <ZDDSriHdl6+LwVl6@tamriel.snowman.net> <ZDDTqZjoWdR/woAC@tamriel.snowman.net> <3286097.1680922218@sss.pgh.pa.us> <ZDDaGFCt5pZMG5Sw@tamriel.snowman.net> <3311389.1680927614@sss.pgh.pa.us> <ZDFTailRZzyGdbXl@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox