public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Evan Jones <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date: Wed, 21 Jun 2023 09:02:35 +0900
Message-ID: <ZJI+G7B/qblD6/[email protected]> (raw)
In-Reply-To: <CA+HWA9ZRRxdL5FFTM4eTDyhmnzC-0tAo1kmu8Mndtjvs4O=G0Q@mail.gmail.com>
References: <CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com>
	<[email protected]>
	<CA+HWA9bTRDf52DHyU+JOoqEALgRGRo5uHUYTFuduoj3cBfer+Q@mail.gmail.com>
	<ZI5i2NCWirDuE/[email protected]>
	<[email protected]>
	<[email protected]>
	<ZI+TK2kch0ZZ/[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+HWA9ZRRxdL5FFTM4eTDyhmnzC-0tAo1kmu8Mndtjvs4O=G0Q@mail.gmail.com>

On Tue, Jun 20, 2023 at 09:04:26AM -0400, Evan Jones wrote:
> My one last suggestion: We *could* revert the backpatching if we are
> concerned about this change, but I'm not personally sure that is necessary.
> As we discussed, this is an unusual corner case in an "extension" type that
> many won't even have enabled.

As a whole, I'd like to think that this is an improvement even for
stable branches with these weird isspace() handlings, so I'm OK with
the current status in all the branches.  There's an argument about \v,
IMO, but I won't fight hard for it either even if it would be more
consistent with the way array values are handled.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../ZJI+G7B%2FqblD6%[email protected]/2-signature.asc)
  download

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
  In-Reply-To: <ZJI+G7B/qblD6/[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox