agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Imseih (AWS), Sami <simseih@amazon.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: Tue, 18 Jun 2024 19:43:36 -0500
Message-ID: <ZnIpuKIW4RO70XeJ@nathan> (raw)
In-Reply-To: <20240618213331.ef2spg3nasksisbi@awork3.anarazel.de>
References: <011CA929-4933-40EA-B1D3-29131FEFBCF0@amazon.com>
	<20240517021646.GA1745636@nathanxps13>
	<Zl4Q7YGslvdL0eYj@nathan>
	<20240603190852.jcibstxflb33hjvu@awork3.anarazel.de>
	<Zl4ZTRdx38sDktRs@nathan>
	<20240603232427.pjiyqggsr7duccr5@awork3.anarazel.de>
	<ZnHZMIJM6rgMVvvM@nathan>
	<20240618204334.i5ar2fie4vbb3fhm@awork3.anarazel.de>
	<ZnH3dQHtE_k6S2sX@nathan>
	<20240618213331.ef2spg3nasksisbi@awork3.anarazel.de>

On Tue, Jun 18, 2024 at 02:33:31PM -0700, Andres Freund wrote:
> Another one:
> 
> Have a general cap of 64, but additionally limit it to something like
>      max(1, min(WORKER_CAP, max_connections / 4))
> 
> so that cases like tap tests don't end up allocating vastly more worker slots
> than actual connection slots.

That's a clever idea.  My only concern would be that we are tethering two
parameters that aren't super closely related, but I'm unsure whether it
would cause any problems in practice.

-- 
nathan





view thread (71+ messages)  latest in thread

Message-ID: <ZnIpuKIW4RO70XeJ@nathan>
Permalink:  ../ZnIpuKIW4RO70XeJ@nathan/
Also on:    postgresql.org/message-id/ZnIpuKIW4RO70XeJ@nathan

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, simseih@amazon.com, pryzby@telsasoft.com
  Subject: Re: allow changing autovacuum_max_workers without restarting
  In-Reply-To: <ZnIpuKIW4RO70XeJ@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox