pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: depesz@depesz.com
Cc: depesz@gmail.com
Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
Date: Sat, 22 Aug 2020 01:04:04 +0900
Message-ID: <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com> (raw)
In-Reply-To: <1803897.1598021621@sss.pgh.pa.us>
References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com>
	<20200819032706.GQ17022@telsasoft.com>
	<20200819072133.jnmtux7qbyxywh6r@nol>
	<CAApHDvrDpJNMpXMS3SNkeUitXrZAFRZ3MrzQG6ieC7vQte6aWA@mail.gmail.com>
	<20200819090429.s7hoyyw4a6jumgkc@nol>
	<CAApHDvr0hMeEDB6HE=GE6vc2kJjCoiWe7z+CVyD9CoAUB+Cpjw@mail.gmail.com>
	<e7361ab4-5b6b-9667-e25b-04ae0b070ded@oss.nttdata.com>
	<CAApHDvqWSk5tVqY9=SwsOF03xOJyrvwoavdDoNjV+2Wk10vsuQ@mail.gmail.com>
	<5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
	<CAApHDvoU32j3FpVFzdf7qrMmhPwd8VTy1g5nAwkh083bWELQxA@mail.gmail.com>
	<CAOBaU_bOrsngOyYhHUZ0tVGzE9FJsB4nviBZQ7zxjehsYmsWPQ@mail.gmail.com>
	<0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com>
	<4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com>
	<b10c76ce-ae6d-85ff-b185-10b00567d4ed@oss.nttdata.com>
	<1803897.1598021621@sss.pgh.pa.us>



On 2020/08/21 23:53, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> Pushed. Thanks!
> 
> Buildfarm shows this patch has got problems under
> -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12

Thanks for the report!

This happens because, in text format, whether "Planning:" line is output
varies depending on the system state. So explain_filter() should ignore
"Planning:" line. Patch attached. I'm now checking whether the patched
version works fine.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:


bugfix.patch (text/plain, 1.2K) download
diff --git a/src/test/regress/expected/explain.out b/src/test/regress/expected/explain.out
index a1ee6c6792..dc7ab2ce8b 100644
--- a/src/test/regress/expected/explain.out
+++ b/src/test/regress/expected/explain.out
@@ -23,6 +23,9 @@ begin
         -- Ignore text-mode buffers output because it varies depending
         -- on the system state
         CONTINUE WHEN (ln ~ ' +Buffers: .*');
+        -- Ignore text-mode "Planning:" line because whether it's output
+        -- varies depending on the system state
+        CONTINUE WHEN (ln = 'Planning:');
         return next ln;
     end loop;
 end;
diff --git a/src/test/regress/sql/explain.sql b/src/test/regress/sql/explain.sql
index 01783c607a..c79116c927 100644
--- a/src/test/regress/sql/explain.sql
+++ b/src/test/regress/sql/explain.sql
@@ -25,6 +25,9 @@ begin
         -- Ignore text-mode buffers output because it varies depending
         -- on the system state
         CONTINUE WHEN (ln ~ ' +Buffers: .*');
+        -- Ignore text-mode "Planning:" line because whether it's output
+        -- varies depending on the system state
+        CONTINUE WHEN (ln = 'Planning:');
         return next ln;
     end loop;
 end;


view thread (25+ messages)  latest in thread

Message-ID: <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com>
Permalink:  ../a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com/
Also on:    postgresql.org/message-id/a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, tgl@sss.pgh.pa.us, pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org, depesz@depesz.com, depesz@gmail.com
  Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
  In-Reply-To: <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox