From: Bryan Green <dbryan.green@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
Date: Mon, 15 Dec 2025 17:10:36 -0600
Message-ID: <a337896e-5bff-490b-afc9-c545f06c014c@gmail.com> (raw)
In-Reply-To: <2259481.1765831157@sss.pgh.pa.us>
References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com>
<001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org>
<CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
<1372793.1763519315@sss.pgh.pa.us>
<CA+hUKGLzXzQcbjEHW08Z6g=mzBkpLtzSJ7Bt2S2XmxP1bwpq8A@mail.gmail.com>
<1377512.1763522154@sss.pgh.pa.us>
<e7b902aa-98ac-4d35-bae3-d7d282a938c2@eisentraut.org>
<1462038.1763567038@sss.pgh.pa.us>
<CA+hUKG+nMv9bmOcARaDFC6rG=SGWC=TwWSRLrxi29oGeRNKemg@mail.gmail.com>
<1881391.1765782112@sss.pgh.pa.us>
<CA+hUKGJaX3AcuKSdEUOZiWc+mzL=+dvGnbMqCvWGY22y6oh9Nw@mail.gmail.com>
<1991599.1765818338@sss.pgh.pa.us>
<c6379076-aabc-4ee8-920b-bd0d18bd2379@gmail.com>
<2117910.1765823286@sss.pgh.pa.us>
<b7d99342-07c3-4d50-af1d-a7b58d2631bd@gmail.com>
<2128694.1765826341@sss.pgh.pa.us>
<2259481.1765831157@sss.pgh.pa.us>
On 12/15/2025 2:39 PM, Tom Lane wrote:
> I wrote:
>> Experimenting here, it looks like 'C.UTF-8' might be accepted
>> everywhere. I even got it to pass on Solaris's not-GNU gettext,
>> which I thought for sure would be the weak spot in the idea.
>> I'll press forward with that.
>
> Hmmm ... the first batch of BF reports show that on some Linux
> machines, it works to set lc_messages to 'C.UTF-8', but nonetheless
> no translation happens. Did you notice any other gating factors?
>
> regards, tom lane
Yes - the LANGUAGE environment variable.
gettext has a priority order for locale selection that's different from
what most people expect. Here's what guess_category_value() does:
Environment Variable Priority (from dcigettext.c):
1. LANGUAGE - GNU extension, colon-separated list (e.g., "en_US:en:C")
2. setlocale(category, NULL) result - the actual locale set
3. LC_ALL - POSIX override for all categories
4. LC_MESSAGES (or other LC_* for that category)
5. LANG - fallback default
LANGUAGE has the highest priority and will override LC_MESSAGES completely.
I am not sure this is the problem, but you probably should unset
LANGUAGE before doing almost anything else in the test script. I
wouldn't be surprised if the CI/BF environments have it set.
Do we know what version of libintl is being used on those BF machines?
There are some marked differences between some versions, which makes
this a little more guesswork than it should be.
---------------------------------------------------------------------
What follows is a walkthrough that just shows that language overrides
lc_messages and how that can impact things. No need to read this unless
you just want more detail.
Assume,
export LANGUAGE=en_US:en
export LC_MESSAGES=C.UTF-8
System has catalogs for C.UTF-8 and es.
#postgres.conf
lc_messages = 'C.UTF-8'
InitPostgres calls pg_perm_setlocale with C.UTF-8.
pg_perm_setlocale calls setlocale(LC_MESSAGES, "C.UTF-8") and succeeds.
setlocale uses setenv to set LC_MESSAGES=C.UTF_8
Now assume an error occurs and gettext is called. A couple of wrappers
down we get to DCIGETTEXT() with a category of LC_MESSAGES. We call
guess_category_value with LC_MESSAGES.
guess_category_value implements the priorty as discussed above. The
very first thing it checks is getenv("LANGUAGE"). If that is not NULL
or an empty string it returns whatever is in LANGUAUGE, which in this
case is en_US:en.
Then back in DCIGETTEXT() we will loop through en_US:en. We try to find
the message catalog with 'en_US' first...and fail because we don't have
that catalog. Then we loop back and try 'en'...and fail again because
we don't have that catalog. One more time through the loop where we
don't have anything left in our list of languages, so we set the locale
to 'C'. Then we check that we don't translate if the locale is a single
C. and we break. Nothing translated.
--
Bryan Green
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dbryan.green@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
In-Reply-To: <a337896e-5bff-490b-afc9-c545f06c014c@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox