From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: daniel@yesql.se <daniel@yesql.se>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Thu, 1 Jul 2021 21:03:58 +0200
Message-ID: <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com> (raw)
In-Reply-To: <745046.1625163264@sss.pgh.pa.us>
References: <3128896.1624742969@sss.pgh.pa.us>
<18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
<622907.1625084114@sss.pgh.pa.us>
<630837.1625092151@sss.pgh.pa.us>
<67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
<9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
<745046.1625163264@sss.pgh.pa.us>
On 01.07.21 20:14, Tom Lane wrote:
> The variant of this I'd been thinking of was
>
> $(shlib): $(OBJS) | $(SHLIB_PREREQS)
> $(LINK.shared) -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK)
> +ifneq (,$(SHLIB_EXTRA_ACTION))
> + $(SHLIB_EXTRA_ACTION)
> +endif
>
> (and similarly in several other places); then libpq's Makefile
> could set SHLIB_EXTRA_ACTION to the desired thing.
Right, that looks sensible. (Maybe the ifneq isn't actually necessary,
since if the variable is not set, nothing would happen.)
> The problem then is, what happens when the extra action fails?
> Without .DELETE_ON_ERROR, the shlib is still there and the next
> make run will think everything's good.
Right. .DELETE_ON_ERROR is already set in Makefile.global, so it's not
necessary to set it again.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, pchampion@vmware.com, daniel@yesql.se, michael@paquier.xyz
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox