From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: Tue, 13 Jul 2021 06:17:01 +0200
Message-ID: <a8d24099-6570-c18a-ae16-bcd221a5eada@enterprisedb.com> (raw)
In-Reply-To: <3185430.1626133592@sss.pgh.pa.us>
References: <3185430.1626133592@sss.pgh.pa.us>
On 13.07.21 01:46, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead. Shouldn't we fix it as
> per attached? This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.
Yes, I think that is correct.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
In-Reply-To: <a8d24099-6570-c18a-ae16-bcd221a5eada@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox