From: Nathan Bossart <nathandbossart@gmail.com>
To: Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: jian he <jian.universality@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
Date: Wed, 23 Apr 2025 11:28:57 -0500
Message-ID: <aAkVSY7pGg4SxSNp@nathan> (raw)
In-Reply-To: <202503241037.pjpyt5j7xrfs@alvherre.pgsql>
References: <CACJufxGLcbFVS8xAC9OBPn0U_2YjKOiHLdmBrtds1j=5eA5MMA@mail.gmail.com>
<202503241037.pjpyt5j7xrfs@alvherre.pgsql>
This one was briefly discussed in an RMT meeting.
On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote:
> On 2025-Mar-24, jian he wrote:
>
>> In the current development branch,
>> virtual generated columns still do not support the domain.
>> you can not change the generation expression if it contains a check
>> constraint on it.
>> so virtual generated columns don't need rewriting.
>>
>> IMHO, the committed doc description didn't mention this exception.
>> we need some text to cover this exception?
>
> I'd add a note about these two things to the open items page, and wait
> to see if we get some of these limitations fixed, so that if we don't,
> we remember to note this limitation in the documentation.
Are we still waiting on something for this, or should we proceed with the
documentation changes? It doesn't seem tremendously urgent, but I noticed
it's been about a month since the last message on this thread.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, alvherre@alvh.no-ip.org, jian.universality@gmail.com, ikedamsh@oss.nttdata.com, rob@xzilla.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
In-Reply-To: <aAkVSY7pGg4SxSNp@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox