pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Rahila Syed <rahilasyed90@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve LWLock tranche name visibility across backends
Date: Tue, 2 Sep 2025 09:45:52 -0500
Message-ID: <aLcDICmlWJbzsE0k@nathan> (raw)
In-Reply-To: <aLVzBrTp731FTw0l@ip-10-97-1-34.eu-west-3.compute.internal>
References: <aK7PyCbPib+/JO2+@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAA5RZ0ve-fHuNYW-ruMwg1y1v7-aCqMm_MiNq1KOdg2Y2-pKDw@mail.gmail.com>
	<aLAFhwpzEwbjiWLG@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAA5RZ0s4ip08Lsk=aYuXGCkBr78jhH=gOau939mhAp-rGuNC3Q@mail.gmail.com>
	<aLCEo0ZMV3vIGRWk@nathan>
	<CAA5RZ0vw-r1qjHw5hUNTzAyCiK3KQ-r+G5ECfWSn+qjdu-fpnw@mail.gmail.com>
	<aLHO-jh-spXWG1pt@nathan>
	<aLJnOnTFSweb2pud@nathan>
	<aLMHVosexT5D-Ybz@nathan>
	<aLVzBrTp731FTw0l@ip-10-97-1-34.eu-west-3.compute.internal>

On Mon, Sep 01, 2025 at 10:18:46AM +0000, Bertrand Drouvot wrote:
> Changes look good.

Thanks for looking.

> Not directly related, but I think that we can get rid of:
> 
> size = add_size(size, LWLOCK_PADDED_SIZE);
> 
> in LWLockShmemSize() and of:
> 
> ptr += LWLOCK_PADDED_SIZE - ((uintptr_t) ptr) % LWLOCK_PADDED_SIZE;
> 
> in CreateLWLocks(), and just make use of CACHELINEALIGN().

Let's take care of the tranche name stuff first.

-- 
nathan





view thread (107+ messages)  latest in thread

Message-ID: <aLcDICmlWJbzsE0k@nathan>
Permalink:  ../aLcDICmlWJbzsE0k@nathan/
Also on:    postgresql.org/message-id/aLcDICmlWJbzsE0k@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, bertranddrouvot.pg@gmail.com, samimseih@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, rahilasyed90@gmail.com
  Subject: Re: Improve LWLock tranche name visibility across backends
  In-Reply-To: <aLcDICmlWJbzsE0k@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox