public inbox for [email protected]  

help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Greg Burd <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Fri, 12 Sep 2025 10:36:18 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<aLpENihhKL4vOxeX@nathan>
	<[email protected]>
	<aLsvPdSHJdRCEk7v@nathan>
	<[email protected]>
	<CAD21AoDijQoXik+U8hf0QptPvNcpjCjfzO_Rp=eCLYSL1D6OOQ@mail.gmail.com>
	<[email protected]>

On Thu, Sep 11, 2025 at 06:56:07AM -0400, Greg Burd wrote:
> Just for reference I started this not to increase coverage, which is a good
> goal just not the one I had.  I was reviewing the API and considering some
> changes based on other work I've done.  Now that I see how deeply baked in
> this code is I think that's unlikely.  Maybe something else distinct for
> bitmaps over 64-bit space at some point will be useful.  I wrote this code
> just to capture the API in test form.

How much does this measure in terms of numbers produced by
coverage-html (see [1])?  The paths taken don't always matter as it
can also be important to check combinations of code paths that are
taken by other tests when checking after edge cases, but that would
give an idea of gain vs extra runtime.  Not objecting to your patch,
just being curious as I am not seeing any numbers posted on this
thread.

[1]: https://www.postgresql.org/docs/devel/regress-coverage.html
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (81+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox