From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David E. Wheeler <david@justatheory.com>
Cc: Mankirat Singh <mankiratsingh1315@gmail.com>
Cc: pg@bowt.ie
Cc: andrew@dunslane.net
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Fri, 31 Oct 2025 09:09:36 -0500
Message-ID: <aQTDIO2xjmFKK0QV@nathan> (raw)
In-Reply-To: <61bd5c85-aaee-4a73-aba6-5b725eacdf27@eisentraut.org>
References: <aPZnY0Icgw1RGaGP@nathan>
<334460.1760980024@sss.pgh.pa.us>
<aPZt4b5beRPxjgI-@nathan>
<aPZ_2a1EQvofxeci@nathan>
<351026.1760988833@sss.pgh.pa.us>
<aPahAGpqBTtvX3YG@nathan>
<1A5A7BE9-4A1B-4A1E-9182-02EBE9A54721@justatheory.com>
<aPfDOD6F4FaJJd7M@nathan>
<655240.1761077617@sss.pgh.pa.us>
<61bd5c85-aaee-4a73-aba6-5b725eacdf27@eisentraut.org>
On Fri, Oct 31, 2025 at 12:02:10PM +0100, Peter Eisentraut wrote:
> What is the reason that this file is supposed to contain the history of
> relevant changes, rather than just the last one?
>
> If you want the history, you could look at the git log of the file itself,
> no?
I think either way would ultimately be fine. I might argue that keeping
the full history in a file with detailed explanations is more accessible
than requiring folks to run
git log .abi-compliance-history
(Plus, if someone doesn't bother to put details in the commit message, you
then have to sleuth further to figure out what changed.)
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, peter@eisentraut.org, tgl@sss.pgh.pa.us, david@justatheory.com, mankiratsingh1315@gmail.com, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
In-Reply-To: <aQTDIO2xjmFKK0QV@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox