From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Date: Wed, 19 Nov 2025 11:30:30 +0900
Message-ID: <aR0rxogaaoBOVDXn@paquier.xyz> (raw)
In-Reply-To: <rsgolpgcheedmh62mhvrpbka4skgczw5x7gf3wjdzyye7mnm4m@uimvk3wrq5ni>
References: <lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
<414029.1755531482@sss.pgh.pa.us>
<qbpxtt77f7adpvbb7kjpvlk7amdvizwe4xvjds2to5qzwopck6@iywnuo6w4pnx>
<aQB3BUxe23YiIOyx@paquier.xyz>
<rej3pew44i4bgpyk3hl42ftjo7vndesbppjbklqiijo6k4gb2b@cc5vxjt6nvio>
<aQQF1N23rkKRHMZA@paquier.xyz>
<CAN55FZ25NO86hpRoZ+vNNpzLU=7TBPg+i92qj+y16Dx0ZhBtig@mail.gmail.com>
<aRuwXU1QZtl5p3OH@paquier.xyz>
<aRuyfhvdPXzTJSpx@paquier.xyz>
<rsgolpgcheedmh62mhvrpbka4skgczw5x7gf3wjdzyye7mnm4m@uimvk3wrq5ni>
On Tue, Nov 18, 2025 at 09:00:39AM -0500, Andres Freund wrote:
> On 2025-11-18 08:40:46 +0900, Michael Paquier wrote:
>> By the way, an extra argument in favor of an isolation test here: the
>> proposed TAP tests only wants to make sure that replay is able to
>> finish on a standby, we don't query it.
>
> I think we should eventually extend the test to run amcheck etc on both
> primary and standby.
It's also something that I was wondering we could do after a main
regression test run for some subset of objects. Not sure that it has
to be part of one test.
>> We are already doing the same in 027_stream_regress.pl for the main
>> regression test suite, and we could expand this TAP test or add a new one
>> that grabs the isolation test suite and runs it in a TAP test with a standby
>> plugged.
>
> I don't think we should add new things to 027_stream_regress, it's already one
> of the two slowest tests and, at least for me, often the test that takes the
> longest to complete in a testrun.
Of course, agreed. That's the part about adding a completely new TAP
test that's able to run one or more isolation test suites, and this
isolation test would be part of it when running things across a
standby and a primary. You're the author of the original test, so
your opinion takes priority over mine, for sure.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, byavuz81@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
In-Reply-To: <aR0rxogaaoBOVDXn@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox