pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: David Fetter <david@fetter.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: psql show URL with help
Date: Fri, 8 Mar 2019 13:45:03 +0100
Message-ID: <aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com> (raw)
In-Reply-To: <20190307220234.GI10435@fetter.org>
References: <40179bd0-fa7d-4108-1991-a20ae9ad5667@2ndquadrant.com>
	<47e071fd-8997-f036-b383-4d80c184adeb@2ndquadrant.com>
	<a8df897e-f1df-b539-a85d-298c678d4180@2ndquadrant.com>
	<20190303181432.GA316@fetter.org>
	<CABUevEyc98E-Jxq-S5jEttiwrdxkAZbpUNsoEt5=DwgVqauY5g@mail.gmail.com>
	<20190303214833.GD10435@fetter.org>
	<CABUevEwUrZWa+8S3_mZ+6HrxUPvFjVU8Os6AKZiKa2KTGnwhQw@mail.gmail.com>
	<b8f27893-a7fb-1dd6-efe8-ca2f228b8578@2ndquadrant.com>
	<CABUevEwNHUe3mHO5QXG9J14ag=7ubbfp6-QxxAOkt+jmfg6rTg@mail.gmail.com>
	<20190307220234.GI10435@fetter.org>

On 2019-03-07 23:02, David Fetter wrote:
>> if (psql_version_is_numeric)
>>  return /docs/psql_version/
>> else if (psql_version ends with 'devel')
>>   return /docs/devel/
>> else
>>   return /docs/{psql_version but with text stripped}/
>>
>> So that e.g. 12beta would return "12", as would 12rc or 12alpha. But
>> 12devel would return "devel".
> 
> That's exactly what I had in mind :)

The outcome of that is exactly what my patch does, but the inputs are
different.  We have PG_MAJORVERSION, which is always a single integer,
and PG_VERSION, which could be 10.9.8 or 11beta5 or 12devel.  The patch does

if (PG_VERSION ends with 'devel')
  return /docs/devel/
else
 return /docs/$PG_MAJORVERSION/

There is no third case.  Your third case of not-numeric-and-not-devel is
correctly covered by the else branch.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (25+ messages)  latest in thread

Message-ID: <aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com>
Permalink:  ../aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com/
Also on:    postgresql.org/message-id/aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, david@fetter.org, magnus@hagander.net
  Subject: Re: psql show URL with help
  In-Reply-To: <aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox