public inbox for [email protected]  

help / color / mirror / Atom feed
From: Bertrand Drouvot <[email protected]>
To: Andres Freund <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: Defend against -ffast-math in meson builds
Date: Thu, 12 Mar 2026 10:26:41 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <dx5yldtsqih2htsd7cz3tfxt5zhuggpeegwllz7wz2r26tll5h@cwhsw4ddfbc5>
References: <[email protected]>
	<vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>
	<[email protected]>
	<[email protected]>
	<abGPko4lPv/[email protected]>
	<[email protected]>
	<dx5yldtsqih2htsd7cz3tfxt5zhuggpeegwllz7wz2r26tll5h@cwhsw4ddfbc5>

Hi,

On Wed, Mar 11, 2026 at 01:48:31PM -0400, Andres Freund wrote:
> Hi,
> 
> On 2026-03-11 12:45:55 -0400, Tom Lane wrote:
> > So no, I don't wanna support this.  But maybe we should move the
> > code-level tests out of the datetime files and into utils/float.h
> > or some such place.
> 
> I think it's probably better to have it in a .c file (maybe float.c), I could
> kinda imagine some extension intentionally enabling -ffast-math, because it
> does something numerically intensive where the incorrectness doesn't matter.

I think that you have a good point about the extension. That said a .h file
could also prevent the extension to make use of -ffast-math "accidentally".

And if they really want it, I think that they could compile the extension with
"-ffast-math -U__FAST_MATH__" to make it work. I just tested it and that works
but now that I write it that looks like an odd combination, so a .c file looks
better.

What do you think?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





view thread (14+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Defend against -ffast-math in meson builds
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox