public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Andres Freund <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: shihao zhong <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Date: Wed, 25 Mar 2026 10:33:48 -0500
Message-ID: <acQAXPXov4cbyUx0@nathan> (raw)
In-Reply-To: <loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
References: <[email protected]>
<aFrSlSz9fi47j5Sr@nathan>
<[email protected]>
<aFwT31Rw-Oj-bgO9@nathan>
<[email protected]>
<rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
<ab2iXwhRe3fFNPfp@nathan>
<aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
<acMGcoUwA9CiPPU1@nathan>
<loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
On Tue, Mar 24, 2026 at 11:29:52PM -0400, Andres Freund wrote:
> On 2026-03-24 16:47:30 -0500, Nathan Bossart wrote:
>> + VacuumParams params_copy;
>
> I'd maybe not name it _copy, but params_local or params_table or such, as
> somehow it seems a bit odd to modify the copy. But I can't really explain why
> it feels odd.
params_local WFM.
> I wonder if more of the code in the function should be updated to use the
> copy, otherwise it seems like it could more easily happen that a part of the
> code not using the modified version is moved until after a modification, and
> the code author assumes the modifications now have taken effect.
Yeah, I was waffling on this. I updated the rest of the function to use
params_local instead.
--
nathan
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
In-Reply-To: <acQAXPXov4cbyUx0@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox