pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Josh Berkus <josh@agliodbs.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Wed, 22 Jul 2015 20:39:22 +0200 (CEST)
Message-ID: <alpine.DEB.2.10.1507222024340.11465@sto> (raw)
In-Reply-To: <55AFD8C6.8010507@agliodbs.com>
References: <alpine.DEB.2.10.1507171544450.26125@sto>
	<CA+Tgmoa=ud6E=4afK3srNj_4j8Cckm4OD_=0=uxSD5JVwsO4rQ@mail.gmail.com>
	<alpine.DEB.2.10.1507211626000.30948@sto>
	<CA+TgmoYQi7sPG+b_19Y4bn2wUPUujsSZ_qOF8nWZTrC1Pbqivg@mail.gmail.com>
	<alpine.DEB.2.10.1507211819460.30948@sto>
	<WM!aa4cff4a48647dfeb51adbc23faaba1f82d825d5edc7fcfe10aa08a36243c5ffb656060d76dd428676a64e1e72c8a672!@asav-2.01.com>
	<55AEDDA4.8020009@agliodbs.com>
	<alpine.DEB.2.10.1507220706260.5636@sto>
	<WM!36f7f6aea11042e334dd8ddca8dd52df3de0913ec1f5bc42bfcc27f3eb60d576c8dac02c33f02b88abead156dfec3da0!@asav-2.01.com>
	<55AFD8C6.8010507@agliodbs.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>


> If so, I would vote for:
>   -f script1.bench:3 -f script2.bench:1
> over:
>   -f script1.bench -w 3 -f script2.bench -w 1

Ok, I'll take that into consideration. Any other opinion out there? The 
current v3 version is:

   -w 3 -f script1.bench -w 1 -f script2.bench

With provision to generate errors if a -w is set but not used,
in two case.

  - in the middle ... -w 4 <no script option...> -w 1 ...
  - in the end ... -w 1 <no script option...>

I can provide -f x:weight easilly, but this mean that there will be no way 
to associate weight for internal scripts. Not orthogonal, not very 
elegant, but no big deal.

> Oh, you misunderstand.  "script1" and "script2" are meant to be 
> user-supplied names which then get reported in things like response time 
> output.  They're labels.

Ok, that is much better. This means that labels should not choose names 
which may interact with other commands, so maybe a list would have been 
nice as well. Anyway, I do not think it is the way to go just for this 
feature.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (92+ messages)  latest in thread

Message-ID: <alpine.DEB.2.10.1507222024340.11465@sto>
Permalink:  ../alpine.DEB.2.10.1507222024340.11465@sto/
Also on:    postgresql.org/message-id/alpine.DEB.2.10.1507222024340.11465@sto

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, josh@agliodbs.com
  Subject: Re: pgbench stats per script & other stuff
  In-Reply-To: <alpine.DEB.2.10.1507222024340.11465@sto>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox