From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Tue, 29 Mar 2016 21:18:21 +0200 (CEST)
Message-ID: <alpine.DEB.2.10.1603292053550.5677@sto> (raw)
In-Reply-To: <20160329175817.GA883652@alvherre.pgsql>
References: <20160329175817.GA883652@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hello,
>> In doing this, I noticed that the latency output is wrong if you use -T
>> instead of -t; it always says the latency is zero because "duration" is
>> zero. I suppose it should be like in the attached instead.
Indeed, I clearly overlooked option -t (transactions) which I never use.
> Patch actually attached here.
Tested. There is a small issue because the \n is missing.
Here is another version which just replaces duration by time_include,
as they should be pretty close, and fixes the style so that it is the same
whether the detailed stats are collected or not, as you pointed out.
>> At the same time, it says "latency average: XYZ" instead of "latency
>> average = XYZ" as in printSimpleStats, which doesn't look terribly
>> important. But the line appears in the SGML docs.
Indeed. The documentation is manually edited when submitting changes so as
to minimize diffs, but then it does not correspond anymore to any actual
output, so it is easy to do it wrong.
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:
[text/x-diff] pgbench-latency-2.patch (1.5K, ../alpine.DEB.2.10.1603292053550.5677@sto/2-pgbench-latency-2.patch)
download | inline diff:diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgmlindex 06cd5db..297af4f 100644--- a/doc/src/sgml/ref/pgbench.sgml+++ b/doc/src/sgml/ref/pgbench.sgml@@ -1253,8 +1253,8 @@ number of clients: 10
number of threads: 1
number of transactions per client: 1000
number of transactions actually processed: 10000/10000
-latency average = 15.844 ms-latency stddev = 2.715 ms+latency average: 15.844 ms+latency stddev: 2.715 ms
tps = 618.764555 (including connections establishing)
tps = 622.977698 (excluding connections establishing)
script statistics:
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.cindex 52d1223..d5380d2 100644--- a/src/bin/pgbench/pgbench.c+++ b/src/bin/pgbench/pgbench.c@@ -3099,8 +3099,8 @@ printSimpleStats(char *prefix, SimpleStats *ss)
double latency = ss->sum / ss->count;
double stddev = sqrt(ss->sum2 / ss->count - latency * latency);
- printf("%s average = %.3f ms\n", prefix, 0.001 * latency);- printf("%s stddev = %.3f ms\n", prefix, 0.001 * stddev);+ printf("%s average: %.3f ms\n", prefix, 0.001 * latency);+ printf("%s stddev: %.3f ms\n", prefix, 0.001 * stddev);
}
/* print out results */
@@ -3155,7 +3155,7 @@ printResults(TState *threads, StatsData *total, instr_time total_time,
else
/* only an average latency computed from the duration is available */
printf("latency average: %.3f ms\n",
- 1000.0 * duration * nclients / total->cnt);+ 1000.0 * time_include * nclients / total->cnt);
if (throttle_delay)
{
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, alvherre@2ndquadrant.com
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <alpine.DEB.2.10.1603292053550.5677@sto>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox